Add defaulting of non-"false" QueryOption fields to "true" #2420
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Create function evaluateBooleanOption() method in QueryOptions - Use evaluateBooleanOption() in the validateOptions() method - Add a test in QueryOptionsTest to test evaluateBooleanOption() resolves #2410
foster33
reviewed
Jun 17, 2024
warehouse/query-core/src/main/java/datawave/query/iterator/QueryOptions.java
Outdated
Show resolved
Hide resolved
lbschanno
requested changes
Jun 17, 2024
warehouse/query-core/src/main/java/datawave/query/iterator/QueryOptions.java
Outdated
Show resolved
Hide resolved
…ryOptions.java Co-authored-by: Laura Schanno <[email protected]>
…ryOptions.java Co-authored-by: foster33 <[email protected]>
ivakegg
requested changes
Jun 26, 2024
| * @return True if the option is null or not "false". False if the option has the value "false" (not case-sensitive). | ||
| */ | ||
| private static boolean evaluateBooleanOption(String value) { | ||
| if (value == null) { |
There was a problem hiding this comment.
OK, this is great. Now we need to add the second part of the ticket which is to update the DefaultQueryPlanner which is setting up these options to use null values instead of "true" when setting up these options on the iterator.
foster33
reviewed
Jul 2, 2024
| @@ -20,6 +20,7 @@ | |||
| import java.util.List; | |||
| import java.util.Map; | |||
| import java.util.Map.Entry; | |||
| import java.util.Objects; | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #2410