Language Expansion Visitor #2411
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
apmoriarty
commented
Jun 10, 2024
apmoriarty
commented
- Added a visitor to support language-based expansion of query terms
- LanguageAwareAnalyzer extends Lucene's Analyzer class.
- Default implementations for most Lucene analyzers provided.
- QueryParameters and QueryOptions can enable language analysis and disable stemming, lemmatization, bigramming or unigramming on a per-language basis
LanguageAwareAnalyzer is based on lucene's Analyzer. Default implementations for most lucene analyzers provided. QueryParameters and QueryOptions can enable language analysis and disable stemming, lemmatization, bigramming or unigramming on a per-language basis
foster33
reviewed
Jun 11, 2024
| <p class="left">Datawave provides limited support for Lucene-based language expansion. A user may specify a set of language short codes that determine which | ||
| analyzers are applied to a query.</p> | ||
| <p class="left">Language analyzers may support stemming, lemmatization, unigramming and bigramming. All options are enabled by default, but Lucene only | ||
| supports certain features by default for certain languages. Stemming is supported for most languages, and bigrams are supported or CJK languages.</p> |
There was a problem hiding this comment.
Suggested change
| supports certain features by default for certain languages. Stemming is supported for most languages, and bigrams are supported or CJK languages.</p> | |
| supports certain features by default for certain languages. Stemming is supported for most languages, and bigrams are supported for CJK languages.</p> |
Seems like this should be 'for'?
hlgp
reviewed
Sep 6, 2024
| /** | ||
| * Base class for lucene-based language analyzers | ||
| */ | ||
| public abstract class LuceneAnalyzer extends LanguageAnalyzer { |
hlgp
reviewed
Sep 6, 2024
| } | ||
|
|
||
| @Test | ||
| public void testDisableLemmas() throws ParseException { |
There was a problem hiding this comment.
Can we get some query tests that validate the Plans when disabling these pieces in addition to just making sure the parameter is set? If they already exist somewhere I haven't found yet, disregard.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.