Feature improve excerpt iterator #2304
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
austin007008
force-pushed
the
feature-improve-excerpt-iterator
branch
from
f56d550
to
7327e3d
Compare
ivakegg
reviewed
Mar 13, 2024
warehouse/query-core/src/main/java/datawave/query/iterator/logic/WordsAndScores.java
Show resolved
Hide resolved
ivakegg
requested changes
Mar 13, 2024
warehouse/query-core/src/main/java/datawave/query/transformer/ExcerptTransform.java
Outdated
Show resolved
Hide resolved
austin007008
force-pushed
the
feature-improve-excerpt-iterator
branch
from
1c16d03
to
b9c0bd9
Compare
jack-gitdev
reviewed
Mar 18, 2024
warehouse/query-core/src/main/java/datawave/query/iterator/logic/WordsAndScores.java
Show resolved
Hide resolved
austin007008
force-pushed
the
feature-improve-excerpt-iterator
branch
4 times, most recently
from
2748049
to
b00394a
Compare
austin007008
force-pushed
the
feature-improve-excerpt-iterator
branch
8 times, most recently
from
216f3c5
to
f832805
Compare
austin007008
force-pushed
the
feature-improve-excerpt-iterator
branch
5 times, most recently
from
219b1e1
to
2f1f8b2
Compare
austin007008
force-pushed
the
feature-improve-excerpt-iterator
branch
4 times, most recently
from
d9b6f68
to
f25999b
Compare
austin007008
force-pushed
the
feature-improve-excerpt-iterator
branch
3 times, most recently
from
141dd68
to
1a90a71
Compare
austin007008
force-pushed
the
feature-improve-excerpt-iterator
branch
3 times, most recently
from
b165000
to
38ac57d
Compare
austin007008
force-pushed
the
feature-improve-excerpt-iterator
branch
4 times, most recently
from
1a13f6f
to
8ee0f26
Compare
austin007008
force-pushed
the
feature-improve-excerpt-iterator
branch
4 times, most recently
from
8da2efd
to
592611a
Compare
austin007008
force-pushed
the
feature-improve-excerpt-iterator
branch
5 times, most recently
from
611153a
to
c8692f8
Compare
| * @param start | ||
| * the index in the array where we want to start setting values to null at | ||
| */ | ||
| private void trimBeginning(String[] termsToOutput, int beforeIndex, float start) { |
There was a problem hiding this comment.
Should start be int rather than float?
There was a problem hiding this comment.
possibly. I don't remember why I made it a float in the first place. Just have to cast the computation for "start" to an int to get everything to compile still.
| * @param start | ||
| * the index in the array where we want to start setting values to null at | ||
| */ | ||
| private void trimEnd(String[] termsToOutput, int afterIndex, float start) { |
There was a problem hiding this comment.
Should start be int rather than float?
There was a problem hiding this comment.
possibly. I don't remember why I made it a float in the first place. Just have to cast the computation for "start" to an int to get everything to compile still.
austin007008
force-pushed
the
feature-improve-excerpt-iterator
branch
from
f9eb209
to
b718ef3
Compare
documentation pt1 format documentation pt2 format set retry to 0 and add log for testing wordsandscores test testing format fix documentation and add new method more tests, fix edge case, documentation test, log, tostring more methods, more tests add getArrSize pass skips on end of cq squash me squash me working except for excerptTest fix test squash me fix before/after method not cq upgrade retry change start offset logic quicker fail and retry make scores output more user readable change output score to 0-1 brackets around whole phrase and add override scores, no scores, onebest excerpt clean and test ln for score and fix skippedword return one best eps fix remove google.sets from excerpt test fix brackets around all phrases in excerpts clean
austin007008
force-pushed
the
feature-improve-excerpt-iterator
branch
from
b718ef3
to
8958c0e
Compare
austin007008
force-pushed
the
feature-improve-excerpt-iterator
branch
from
8958c0e
to
10bbe6a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.