-
Notifications
You must be signed in to change notification settings - Fork 244
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updating unit tests based on new typeMetadata format #2286
Open
mineralntl
wants to merge
19
commits into
integration
Choose a base branch
from
task/typeMetadataSerializationSupport
base: integration
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
avgAGB
previously approved these changes
Feb 27, 2024
ivakegg
previously approved these changes
Feb 27, 2024
mineralntl
force-pushed
the
task/typeMetadataSerializationSupport
branch
from
February 29, 2024 14:44
fb22cdf
to
b0da3c6
Compare
…tionalSecurityAgency/datawave into task/typeMetadataSerializationSupport
hlgp
previously approved these changes
Mar 4, 2024
…tionalSecurityAgency/datawave into task/typeMetadataSerializationSupport
mineralntl
force-pushed
the
task/typeMetadataSerializationSupport
branch
from
March 7, 2024 20:08
88cd445
to
5137d97
Compare
…tionalSecurityAgency/datawave into task/typeMetadataSerializationSupport
mineralntl
force-pushed
the
task/typeMetadataSerializationSupport
branch
from
March 18, 2024 13:16
4971a61
to
9991da1
Compare
mineralntl
force-pushed
the
task/typeMetadataSerializationSupport
branch
2 times, most recently
from
March 25, 2024 02:59
5edf100
to
d58c82b
Compare
mineralntl
force-pushed
the
task/typeMetadataSerializationSupport
branch
from
April 3, 2024 17:39
d58c82b
to
13c8fac
Compare
mineralntl
force-pushed
the
task/typeMetadataSerializationSupport
branch
2 times, most recently
from
April 17, 2024 14:46
1173287
to
876113f
Compare
mineralntl
force-pushed
the
task/typeMetadataSerializationSupport
branch
3 times, most recently
from
April 26, 2024 16:31
643fc9b
to
0d3eeef
Compare
mineralntl
force-pushed
the
task/typeMetadataSerializationSupport
branch
from
May 9, 2024 13:38
0d3eeef
to
ca455dd
Compare
mineralntl
force-pushed
the
task/typeMetadataSerializationSupport
branch
from
May 17, 2024 16:38
ca455dd
to
695bf60
Compare
…tionalSecurityAgency/datawave into task/typeMetadataSerializationSupport
hlgp
approved these changes
Jun 24, 2024
alerman
approved these changes
Jun 24, 2024
This PR is technically optional due to the ability to consume and parse the previously used TypeMetadata string format. Merge (or not) whenever we feel like it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This branch will fail until the corresponding typeMetadata serialization changes from the metdata-utils repo are merged and tagged - the metadata-utils version in this branch's pom (or whatever is merged into integration) will also need to be updated accordingly.