Correct DROP state for normalization bug. #2285
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rdhayes68
requested review from
mineralntl and
hlgp
and removed request for
mineralntl and
hlgp
mineralntl
reviewed
Feb 23, 2024
...ngest-core/src/main/java/datawave/ingest/mapreduce/handler/shard/ShardedDataTypeHandler.java
Show resolved
Hide resolved
mineralntl
reviewed
Feb 23, 2024
...ngest-core/src/main/java/datawave/ingest/mapreduce/handler/shard/ShardedDataTypeHandler.java
Show resolved
Hide resolved
|
looks good so far. will take a closer look next week |
hlgp
reviewed
Mar 22, 2024
...ngest-core/src/main/java/datawave/ingest/mapreduce/handler/shard/ShardedDataTypeHandler.java
Outdated
Show resolved
Hide resolved
hlgp
reviewed
Mar 22, 2024
...ngest-core/src/main/java/datawave/ingest/mapreduce/handler/shard/ShardedDataTypeHandler.java
Outdated
Show resolved
Hide resolved
hgklohr
approved these changes
Jul 25, 2024
hlgp
approved these changes
Jul 25, 2024
hgklohr
added a commit
that referenced
this pull request
Jul 25, 2024
* Correct DROP state for normalization bug. * Update code format * Updated from code review comments * Correct DROP state for normalization bug. * added NormalizedContentInterface test * Correct DROP state for normalization bug. * Add test for ShardedDataTypeHandler * Update test for ShardedDataTypeHandler Failure Policy. * Update test for ShardedDataTypeHandler Failure Policy. * Update test for ShardedDataTypeHandler Failure Policy. * Update based on code review comments. * Update based on code review comments. --------- Co-authored-by: hgklohr <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.