Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated to fill out the query parameters prior to creating Query object #2202

Merged
merged 5 commits into from
Dec 20, 2023

Conversation

ivakegg
Copy link
Collaborator

@ivakegg ivakegg commented Dec 19, 2023

No description provided.

@ivakegg ivakegg added Integration Tested accepted accepted for merging into a specific branch labels Dec 19, 2023
@billoley billoley self-requested a review December 20, 2023 15:01
Copy link
Collaborator

@billoley billoley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Request better variable names than params vs parms vs queryParameters

apmoriarty
apmoriarty previously approved these changes Dec 20, 2023
Copy link
Collaborator

@apmoriarty apmoriarty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@keith-ratcliffe keith-ratcliffe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@ivakegg ivakegg merged commit 0de9a2b into release/version5.2 Dec 20, 2023
3 checks passed
ivakegg added a commit that referenced this pull request Dec 20, 2023
…ct (#2202)

* Updated to fill out the query parameters prior to creating Query object
* Added test case
ivakegg added a commit that referenced this pull request Dec 20, 2023
…ct (#2202)

* Updated to fill out the query parameters prior to creating Query object
* Added test case
ivakegg added a commit that referenced this pull request Dec 20, 2023
…ct (#2202)

* Updated to fill out the query parameters prior to creating Query object
* Added test case
ivakegg added a commit that referenced this pull request Dec 20, 2023
…ct (#2202)

* Updated to fill out the query parameters prior to creating Query object
* Added test case
ivakegg added a commit that referenced this pull request Dec 20, 2023
…ct (#2202)

* Updated to fill out the query parameters prior to creating Query object
* Added test case
ivakegg added a commit that referenced this pull request Dec 20, 2023
…ct (#2202)

* Updated to fill out the query parameters prior to creating Query object
* Added test case
ivakegg added a commit that referenced this pull request Dec 20, 2023
…ct (#2202)

* Updated to fill out the query parameters prior to creating Query object
* Added test case
ivakegg added a commit that referenced this pull request Dec 20, 2023
…ct (#2202)

* Updated to fill out the query parameters prior to creating Query object
* Added test case
@ivakegg ivakegg deleted the bugfix/lookupContentUUID branch February 12, 2024 21:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accepted accepted for merging into a specific branch Integration Tested
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants