Fail when AndIterator drops IndexOnly term #2081
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
apmoriarty
commented
Sep 6, 2023
warehouse/query-core/src/test/java/datawave/query/iterator/logic/AndOrIteratorIT.java
Show resolved
Hide resolved
ivakegg
reviewed
Sep 8, 2023
warehouse/query-core/src/main/java/datawave/query/iterator/logic/AndIterator.java
Outdated
Show resolved
Hide resolved
FineAndDandy
requested changes
Sep 13, 2023
warehouse/query-core/src/test/java/datawave/query/iterator/logic/AndIteratorIT.java
Show resolved
Hide resolved
warehouse/query-core/src/main/java/datawave/query/iterator/NestedIterator.java
Outdated
Show resolved
Hide resolved
warehouse/query-core/src/main/java/datawave/query/iterator/logic/AndIterator.java
Outdated
Show resolved
Hide resolved
warehouse/query-core/src/test/java/datawave/query/iterator/logic/AndIteratorTest.java
Outdated
Show resolved
Hide resolved
warehouse/query-core/src/main/java/datawave/query/iterator/logic/OrIterator.java
Outdated
Show resolved
Hide resolved
warehouse/query-core/src/main/java/datawave/query/iterator/logic/AndIterator.java
Show resolved
Hide resolved
warehouse/query-core/src/test/java/datawave/query/iterator/logic/IndexIteratorTest.java
Outdated
Show resolved
Hide resolved
dtspence
reviewed
Sep 21, 2023
warehouse/query-core/src/main/java/datawave/query/iterator/logic/AndIterator.java
Show resolved
Hide resolved
IndexIteratorTest now supports interupted iterator exception handling
…ow check all iterators for non event fields
…union that later throws an exception on a next call.
apmoriarty
force-pushed
the
bugfix/and-iterator-drop-index-only-term
branch
from
d5dd944
to
2ff49a8
Compare
ivakegg
reviewed
Jul 24, 2024
warehouse/query-core/src/main/java/datawave/query/iterator/logic/AndIterator.java
Show resolved
Hide resolved
hlgp
reviewed
Jul 29, 2024
warehouse/query-core/src/test/java/datawave/query/iterator/logic/NegationFilterTest.java
Outdated
Show resolved
Hide resolved
ivakegg
reviewed
Jul 30, 2024
warehouse/query-core/src/main/java/datawave/query/iterator/logic/AndIterator.java
Show resolved
Hide resolved
avgAGB
previously approved these changes
Aug 1, 2024
alerman
previously approved these changes
Aug 2, 2024
hlgp
previously approved these changes
Aug 2, 2024
ivakegg
previously approved these changes
Aug 5, 2024
apmoriarty
dismissed stale reviews from ivakegg, hlgp, alerman, and avgAGB
via
c30922c
FineAndDandy
approved these changes
Aug 7, 2024
ivakegg
approved these changes
Aug 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addressed two different bugs in the AndIterator
contextIncludesiterators when context is necessaryAs a note: several additional defects were discovered by testing with random inputs. These unit tests in the
AndOrIteratorITare disabled and a fix for those will be coming later.