Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mainly formatting tidy ups to the main module #5

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

timlinux
Copy link

@timlinux timlinux commented Mar 9, 2016

  • wrap to 80 cols
  • removed unused imports
  • pythonic naming convention (e.g. underscore separated names)
  • don't shadow globals / outer scopes in inner scope vars
  • fix spacing
  • generally make it fit my a-type brain better :-P

timlinux added 2 commits March 9, 2016 23:26
…ner script for OSX. Note the help dialog causes an error with the current text so I commented out the offending lines.
@timlinux
Copy link
Author

timlinux commented Mar 9, 2016

I should mention it still doesn't run right (no rendering) for me on OSX - working on that still. You may want to test my changes locally before merging to be sure I never broke something on linux / win.

@NathanW2
Copy link
Owner

NathanW2 commented Mar 9, 2016

Thanks. I'm doing a bit of a rework so you might get conflicts

On Thu, 10 Mar 2016 7:50 am Tim Sutton [email protected] wrote:

I should mention it still doesn't run right (no rendering) for me on OSX -
working on that still. You may want to test my changes locally before
merging to be sure I never broke something on linux / win.


Reply to this email directly or view it on GitHub
#5 (comment).

@NathanW2
Copy link
Owner

NathanW2 commented Mar 9, 2016

Will test once I'm done

On Thu, 10 Mar 2016 7:54 am Nathan Woodrow [email protected] wrote:

Thanks. I'm doing a bit of a rework so you might get conflicts

On Thu, 10 Mar 2016 7:50 am Tim Sutton [email protected] wrote:

I should mention it still doesn't run right (no rendering) for me on OSX

  • working on that still. You may want to test my changes locally before
    merging to be sure I never broke something on linux / win.


Reply to this email directly or view it on GitHub
#5 (comment).

@NathanW2
Copy link
Owner

@timlinux for the no rendering. You might just have to put a bunch of logging at char setting and colour setting, etc

I will test on the OSX install when I get some time.

@timlinux
Copy link
Author

Thanks. I'm doing a bit of a rework so you might get conflicts

No problem - I will fix them as they happen

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants