Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Visual layout improvements especially for landing page #1780

Merged
merged 13 commits into from
Mar 20, 2025

Conversation

osma
Copy link
Member

@osma osma commented Mar 18, 2025

Reasons for creating this PR

The landing page didn't follow the visual spec very well and there were issues with font sizes, with some users seeing absurdly large text. This PR attempts to fix the font size inconsistency issue by changing all font-size declarations to use rem units. There are many visual improvements to the landing page layout as well as some adjustments that also affect other page types.

Link to relevant issue(s), if any

Description of the changes in this PR

  • always specify font sizes in rem (except for the :root element, where em is better)
  • adjust landing page layout to better follow visual spec
  • make landing page layout responsive & columns equal height
  • adjust footer layout to better follow visual spec, at least on landing page
  • set landing page default headline to "Vocabularies" (can be overridden in config.ttl)
  • many small adjustments to font sizes, colors etc., also affecting other page types

Known problems or uncertainties in this PR

  • I hope I didn't break anything too badly when changing CSS rules

Checklist

  • phpUnit tests pass locally with my changes
  • I have added tests that show that the new code works, or tests are not relevant for this PR (e.g. only HTML/CSS changes)
  • The PR doesn't reduce accessibility of the front-end code (e.g. tab focus, scaling to different resolutions, use of .sr-only class, color contrast)
  • The PR doesn't introduce unintended code changes (e.g. empty lines or useless reindentation)

@osma osma added this to the 3.0 milestone Mar 18, 2025
@osma osma self-assigned this Mar 18, 2025
@osma osma requested a review from UnniKohonen March 19, 2025 09:02
Copy link
Contributor

@UnniKohonen UnniKohonen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks much better than it did before but there are some things I noticed that should still be fixed:

  • The main sans-serif font is not set correctly
  • To me the Skosmos logo looks a little big on the landing in comparison to the new sizing
  • Vocab titles on vocab home page are no longer centered vertically

I also commented some minor code chages


<div class="bg-medium px-5 py-5 flex-grow-1 d-flex align-items-center" id="info-box">
<a class="fs-5 text-dark text-decoration-none" href="#">Skosmos is open source and on GitHub -></a>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A font awesome arrow icon could be added here.

@osma
Copy link
Member Author

osma commented Mar 19, 2025

Thanks for the comments @UnniKohonen! I think I've now implemented all the suggestions, except the horrible way of constructing links to vocabularies, which I think is a separate problem a bit out of scope for this PR, but we have issue #1565 to remind us about it.

@osma osma marked this pull request as ready for review March 19, 2025 13:52
Copy link
Contributor

@UnniKohonen UnniKohonen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@osma osma merged commit 78e83dc into main Mar 20, 2025
11 checks passed
@osma osma deleted the issue1480-landing-page-visual-layout branch March 20, 2025 14:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Issue/PR closed
Development

Successfully merging this pull request may close these issues.

Avoid specifying font sizes in px
2 participants