-
Notifications
You must be signed in to change notification settings - Fork 96
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Visual layout improvements especially for landing page #1780
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks much better than it did before but there are some things I noticed that should still be fixed:
- The main sans-serif font is not set correctly
- To me the Skosmos logo looks a little big on the landing in comparison to the new sizing
- Vocab titles on vocab home page are no longer centered vertically
I also commented some minor code chages
src/view/landing.twig
Outdated
|
||
<div class="bg-medium px-5 py-5 flex-grow-1 d-flex align-items-center" id="info-box"> | ||
<a class="fs-5 text-dark text-decoration-none" href="#">Skosmos is open source and on GitHub -></a> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A font awesome arrow icon could be added here.
|
Thanks for the comments @UnniKohonen! I think I've now implemented all the suggestions, except the horrible way of constructing links to vocabularies, which I think is a separate problem a bit out of scope for this PR, but we have issue #1565 to remind us about it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Reasons for creating this PR
The landing page didn't follow the visual spec very well and there were issues with font sizes, with some users seeing absurdly large text. This PR attempts to fix the font size inconsistency issue by changing all font-size declarations to use
rem
units. There are many visual improvements to the landing page layout as well as some adjustments that also affect other page types.Link to relevant issue(s), if any
Description of the changes in this PR
rem
(except for the:root
element, whereem
is better)Known problems or uncertainties in this PR
Checklist
.sr-only
class, color contrast)