Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add wrapper scripts for common translation operations #1770

Merged
merged 2 commits into from
Mar 13, 2025
Merged

Conversation

osma
Copy link
Member

@osma osma commented Mar 12, 2025

Reasons for creating this PR

While reviewing the documentation for translations in Skosmos 3, it became apparent that the current commands for common operations such as extract, pull and push are quite unwieldy. This PR adds wrapper shell scripts that make them much easier.

Link to relevant issue(s), if any

Description of the changes in this PR

  • add .env.local into .gitignore (commonly used to hold Lokalise API keys that shouldn't be committed to version control)
  • add the scripts extract-translations, push-translations and pull-translations

Known problems or uncertainties in this PR

The documentation needs to be updated as well so it encourages using these scripts.

Checklist

  • phpUnit tests pass locally with my changes
  • I have added tests that show that the new code works, or tests are not relevant for this PR (e.g. only HTML/CSS changes)
  • The PR doesn't reduce accessibility of the front-end code (e.g. tab focus, scaling to different resolutions, use of .sr-only class, color contrast)
  • The PR doesn't introduce unintended code changes (e.g. empty lines or useless reindentation)

@osma osma added this to the 3.0 milestone Mar 12, 2025
@osma osma self-assigned this Mar 12, 2025
Copy link
Contributor

@UnniKohonen UnniKohonen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested the scripts and they seem to be working as expected. LGTM!

@osma osma merged commit 69dd1e1 into main Mar 13, 2025
11 checks passed
@osma
Copy link
Member Author

osma commented Mar 13, 2025

I changed the documentation to use these scripts instead of the full commands.

@osma osma deleted the translation-scripts branch March 13, 2025 09:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Issue/PR closed
Development

Successfully merging this pull request may close these issues.

2 participants