Implement infinite scrolling in new and deprecated view #1766
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
joelit
approved these changes
Mar 13, 2025
| @@ -67,9 +72,52 @@ function startChangesApp () { | |||
|
|
|||
| this.changedConcepts = changesByDate | |||
| this.loadingConcepts = false | |||
| this.currentOffset = 200 | |||
| // Add scrolling event listener back after changes are loaded | |||
| this.$refs.tabChanges.$refs.list.addEventListener('scroll', this.handleScrollEvent) | |||
| console.log('changes', this.changedConcepts) | |||
There was a problem hiding this comment.
Maybe we don't need the logging anymore at this point
| return data.json() | ||
| }) | ||
| .then(data => { | ||
| console.log('data', data) |
There was a problem hiding this comment.
Ditto. Maybe we don't need the logging anymore at this point.
| if (data.changeList.length > 0) { | ||
| this.$refs.tabChanges.$refs.list.addEventListener('scroll', this.handleScrollEvent) | ||
| } | ||
| console.log('changes', this.changedConcepts) |
There was a problem hiding this comment.
Ditto. Maybe we don't need the logging anymore at this point.
|
I created a separate issue about logging levels - #1773 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reasons for creating this PR
Changes view in sidebar does not currently load more concepts as the list is scrolled in Skosmos 3. This PR adds functionality to address this.
Link to relevant issue(s), if any
Description of the changes in this PR
Addresses requirement 7 in #1735
Known problems or uncertainties in this PR
Checklist
.sr-onlyclass, color contrast)