-
Notifications
You must be signed in to change notification settings - Fork 43
Drop Python 3.9 support #849
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #849 +/- ##
==========================================
+ Coverage 99.63% 99.64% +0.01%
==========================================
Files 99 99
Lines 7349 7349
==========================================
+ Hits 7322 7323 +1
+ Misses 27 26 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Codecov shows a number of indirect changes to coverage. Basically around 20 code lines related to backends that are not installed are not being covered by the tests. Why is that? Is it possible that all optional features get installed for all Python versions, or something along those lines? |
When versions were rotated and new dependencies got installed to a Python version specific job, the old dependencies remained in cache, so all features were available. I cleared the caches. Now indirect changes actually increases with few lines (increase is surprising, why?). |
Indeed that's a bit mysterious. I can't think of a reason for the change. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Drops Annif's support for Python 3.9, rotates Python versions in CI/CD pipeline and updates Python version for Scrutinizer to 3.12.