Skip to content

Drop Python 3.9 support #849

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 12, 2025
Merged

Drop Python 3.9 support #849

merged 2 commits into from
May 12, 2025

Conversation

juhoinkinen
Copy link
Member

@juhoinkinen juhoinkinen commented Apr 7, 2025

Drops Annif's support for Python 3.9, rotates Python versions in CI/CD pipeline and updates Python version for Scrutinizer to 3.12.

@juhoinkinen juhoinkinen added maintenance github_actions Pull requests that update GitHub Actions code labels Apr 7, 2025
@juhoinkinen juhoinkinen added this to the 1.4 milestone Apr 7, 2025
Copy link

codecov bot commented Apr 7, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.64%. Comparing base (bf802c7) to head (72a6303).
Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #849      +/-   ##
==========================================
+ Coverage   99.63%   99.64%   +0.01%     
==========================================
  Files          99       99              
  Lines        7349     7349              
==========================================
+ Hits         7322     7323       +1     
+ Misses         27       26       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link

sonarqubecloud bot commented Apr 7, 2025

@juhoinkinen juhoinkinen changed the title WIP Drop Python 3.9 support Drop Python 3.9 support Apr 7, 2025
@juhoinkinen juhoinkinen marked this pull request as ready for review April 7, 2025 12:29
@osma
Copy link
Member

osma commented Apr 8, 2025

Codecov shows a number of indirect changes to coverage. Basically around 20 code lines related to backends that are not installed are not being covered by the tests. Why is that? Is it possible that all optional features get installed for all Python versions, or something along those lines?

@juhoinkinen
Copy link
Member Author

juhoinkinen commented Apr 9, 2025

When versions were rotated and new dependencies got installed to a Python version specific job, the old dependencies remained in cache, so all features were available.

I cleared the caches. Now indirect changes actually increases with few lines (increase is surprising, why?).

@osma
Copy link
Member

osma commented Apr 9, 2025

Indeed that's a bit mysterious. I can't think of a reason for the change.

Copy link
Member

@osma osma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@juhoinkinen juhoinkinen merged commit 9aed018 into main May 12, 2025
16 checks passed
@juhoinkinen juhoinkinen deleted the drop-python3.9-support branch May 12, 2025 08:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
github_actions Pull requests that update GitHub Actions code maintenance
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants