ci: use release/v1 tag for pypa/gh-action-pypi-publish#107
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #107 +/- ##
=======================================
Coverage 95.63% 95.63%
=======================================
Files 8 8
Lines 1719 1719
=======================================
Hits 1644 1644
Misses 75 75 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
The Docker-based action has no container image published for the commit SHA that zizmor pinned. Use the rolling release/v1 tag which always has a matching image in ghcr.io.
pesap
force-pushed
the
fix/pypi-publish-action
branch
from
d0dab1c to
776388f
Compare
pesap
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
publish-testpypiandpublish-pypijobs in the release workflow106e0b0b...) withrelease/v1rolling tag forpypa/gh-action-pypi-publishWhy
The zizmor CI hardening PR (#105) pinned
pypa/gh-action-pypi-publishto a commit SHA. This action is Docker-based, and its container registry only publishes images by release tag, not by commit SHA. The result:docker: Error response from daemon: manifest unknown.Using
release/v1is the recommended approach for this action and always has a matching Docker image.Impact
The v1.3.3 release failed to publish to TestPyPI/PyPI. After merging this fix, re-running the failed release workflow will complete the publish.