Skip to content

Nuclear with thermal connection with HTSE - #807

Merged
jaredthomas68 merged 88 commits into
NatLabRockies:developfrom
jaredthomas68:nuchtse
Jul 31, 2026
Merged

Nuclear with thermal connection with HTSE#807
jaredthomas68 merged 88 commits into
NatLabRockies:developfrom
jaredthomas68:nuchtse

Conversation

@jaredthomas68

@jaredthomas68 jaredthomas68 commented Jul 20, 2026

Copy link
Copy Markdown
Collaborator

Nuclear with thermal connection with HTSE

This pull request adds a nuclear model capable of thermal integration and high temperature steam electrolysis. The models are coupled, but can be used individually and coupled with other components. This PR replaces #761.

Section 1: Type of Contribution

  • Feature Enhancement
    • Framework
    • New Model
    • Updated Model
    • Tools/Utilities
    • Other (please describe):
  • Bug Fix
  • Documentation Update
  • CI Changes
  • Other (please describe):

Section 2: Draft PR Checklist

  • Open draft PR
  • Describe the feature that will be added
  • Fill out TODO list steps
  • Describe requested feedback from reviewers on draft PR
  • Complete Section 8: New Model Checklist (if applicable)

TODO:

  • Step 1
  • Step 2

Type of Reviewer Feedback Requested (on Draft PR)

Structural feedback:

Implementation feedback:

Other feedback:

Section 3: General PR Checklist

  • PR description thoroughly describes the new feature, bug fix, etc.
  • Added tests for new functionality or bug fixes
  • Tests pass (If not, and this is expected, please elaborate in the Section 6: Test Results)
  • Documentation
    • Docstrings are up-to-date
    • Related docs/ files are up-to-date, or added when necessary
    • Documentation has been rebuilt successfully
    • Examples have been updated (if applicable)
  • CHANGELOG.md
    • At least one complete sentence has been provided to describe the changes made in this PR
    • After the above, a hyperlink has been provided to the PR using the following format:
      "A complete thought. [PR XYZ]((https://github.com/NatLabRockies/H2Integrate/pull/XYZ)", where
      XYZ should be replaced with the actual number.

Section 4: Related Issues

Section 5: Impacted Areas of the Software

Section 5.1: New Files

  • examples/36_nuclear_reactor_htse/driver_config.yaml

    • driver.optimization / design_variables: Adds optimization inputs for the thermal nuclear + HTSE example so reactor dispatch and HTSE sizing can be varied.
  • examples/36_nuclear_reactor_htse/nuclear_reactor_thermal_htse.yaml

    • config references: Adds the top-level example entrypoint that links the driver, plant, and technology configuration files.
  • examples/36_nuclear_reactor_htse/plant_config.yaml

    • technology_interconnections / finance_parameters: Adds the plant wiring and finance subgroup definitions for coupled nuclear electricity, process heat, HTSE hydrogen production, and grid sales.
  • examples/36_nuclear_reactor_htse/run_nuclear_reactor_thermal.py

    • module script body: Adds a runnable example that updates HTSE refurbishment inputs, executes the model, reports LCOE/LCOH, and plots electricity, heat, and hydrogen outputs.
  • examples/36_nuclear_reactor_htse/tech_config.yaml

    • technologies: Adds the thermal nuclear reactor, HTSE, feedstock, demand, and grid component definitions needed to run the integrated example.
  • h2integrate/converters/hydrogen/htse_electrolyzer.py

    • HTSEPerformanceModel: Adds a simplified HTSE performance model that converts available heat and electricity into hydrogen production, water use, efficiency, and replacement outputs.
    • HTSECostModel: Adds a size-based HTSE cost model that computes CapEx and fixed OpEx from installed electrolyzer capacity.
  • h2integrate/converters/hydrogen/test/test_htse_electrolyzer.py

    • HTSE unit tests: Adds coverage for rated operation, turndown shutoff, and cost-model behavior for the new HTSE models.
  • h2integrate/converters/nuclear/nuclear_plant_thermal.py

    • SimpleThermalNuclearReactorPerformanceModel: Adds a thermal nuclear reactor model that dispatches between electricity generation and process heat delivery.
    • SimpleThermalNuclearReactorCostModel: Adds a reactor cost model that computes capital, fixed operating, and variable operating costs.
  • h2integrate/converters/nuclear/test/test_nuclear_plant_thermal.py

    • thermal reactor unit tests: Adds coverage for heat-mode dispatch, electricity-mode dispatch, rated-capacity clipping, and reactor cost calculations.

Section 5.2: Modified Files

  • examples/test/test_all_examples.py

    • test_nuclear_reactor_htse_example: Adds an integration test for the new thermal nuclear + HTSE example to validate annual electricity, hydrogen output, grid exports, and thermal-balance behavior.
  • h2integrate/converters/hydrogen/__init__.py

    • module exports: Adds HTSEPerformanceModel and HTSECostModel to the hydrogen converter package exports.
  • h2integrate/converters/nuclear/__init__.py

    • module exports: Adds SimpleThermalNuclearReactorPerformanceModel and SimpleThermalNuclearReactorCostModel to the nuclear converter package exports.
  • h2integrate/core/supported_models.py

    • supported_models: Registers the new HTSE and thermal nuclear model classes so they can be instantiated from YAML configuration.
  • h2integrate/transporters/pipe.py

    • PipePerformanceModel.setup: Updates water pipe units from galUS to galUS/h so water transport matches the HTSE feedstock rate units.

Section 6: Additional Supporting Information

Section 7: Test Results, if applicable

Section 8 (Optional): New Model Checklist

  • Model Structure:
    • Follows established naming conventions outlined in docs/developer_guide/coding_guidelines.md
    • Used attrs class to define the Config to load in attributes for the model
      • If applicable: inherit from BaseConfig or CostModelBaseConfig
    • Added: initialize() method, setup() method, compute() method
      • If applicable: inherit from CostModelBaseClass
  • Integration: Model has been properly integrated into H2Integrate
    • Add the new model to the appropriate __init__.py file to ensure it is properly imported and used in supported_models.py
    • Added to supported_models.py
    • If a new commodity_type is added, update create_financial_model in h2integrate_model.py
  • Tests: Unit tests have been added for the new model
    • Pytest-style unit tests
    • Unit tests are in a "test" folder within the folder a new model was added to
    • If applicable add integration tests
  • Example: If applicable, a working example demonstrating the new model has been created
    • Input file comments
    • Run file comments
    • Example has been tested and runs successfully in test_all_examples.py
  • Documentation:
    • Write docstrings using the Google style
    • Model added to the main models list in docs/user_guide/model_overview.md
      • Model documentation page added to the appropriate docs/ section
      • <model_name>.md is added to the _toc.yml
    • Run generate_class_hierarchy.py to update the class hierarchy diagram in docs/developer_guide/class_structure.md

Daniel Mark Mikkelson and others added 30 commits April 14, 2026 10:58
… how it uses electricity when heat is not available.
…optimization and we need a single analysis test value in this case
@jaredthomas68
jaredthomas68 requested review from elenya-grant and johnjasa and removed request for elenya-grant July 30, 2026 16:05

@johnjasa johnjasa left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for iterating here! I have small suggestions for clarity.

Comment thread h2integrate/converters/hydrogen/htse_electrolyzer.py Outdated
cluster_rating_MW: float = field(validator=gt_zero)
uptime_hours_until_eol: int = field(default=80000, validator=gt_zero)
turndown_ratio: float = field(default=0.1, validator=gt_zero)
pressure_H2: float = field(default=1.0, validator=gt_zero)

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
pressure_H2: float = field(default=1.0, validator=gt_zero)

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

Comment on lines +210 to +212
nuclear_reactor_upfront_cost: float = field(validator=gt_zero)
nuclear_reactor_fixed_om_cost: float = field(validator=gt_zero)
nuclear_reactor_variable_om_cost: float = field(validator=gt_zero)

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggestion: remove nuclear_reactor_ from all these variables throughout

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@jaredthomas68
jaredthomas68 requested a review from johnjasa July 31, 2026 16:24
@jaredthomas68
jaredthomas68 enabled auto-merge (squash) July 31, 2026 16:27
@jaredthomas68
jaredthomas68 disabled auto-merge July 31, 2026 16:30
@jaredthomas68
jaredthomas68 requested review from elenya-grant and removed request for elenya-grant July 31, 2026 16:32
@jaredthomas68
jaredthomas68 enabled auto-merge (squash) July 31, 2026 16:33
@jaredthomas68
jaredthomas68 merged commit b55061d into NatLabRockies:develop Jul 31, 2026
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants