Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #391 +/- ##
==========================================
- Coverage 54.52% 54.49% -0.04%
==========================================
Files 61 61
Lines 5652 5652
Branches 530 530
==========================================
- Hits 3082 3080 -2
- Misses 2525 2526 +1
- Partials 45 46 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Pull request overview
This PR fixes save_run_meta() manifest path serialization so it can produce relative paths even when a target directory is not a descendant of dirs.out (e.g., sibling directories higher up the tree), addressing relate_to-style failures when the common ancestor is above dirs.out.
Changes:
- Update manifest serialization to use
Path.relative_to(..., walk_up=True)when writingmeta.json. - Add unit tests covering sibling directories, multi-level walk-ups, nested output paths, and external directories.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
compass/utilities/finalize.py |
Writes manifest paths using relative_to(..., walk_up=True) to support non-descendant targets. |
tests/python/unit/utilities/test_utilities_finalize.py |
Adds test coverage for new manifest path behaviors across several directory topologies. |
You can also share your feedback on Copilot code review. Take the survey.
Fix issue with
relative_tothat couldn't resolve paths with a common ancestor a few folders up