Skip to content

Fix directory issue#391

Merged
ppinchuk merged 3 commits intomainfrom
pp/fix_dir_issue
Mar 11, 2026
Merged

Fix directory issue#391
ppinchuk merged 3 commits intomainfrom
pp/fix_dir_issue

Conversation

@ppinchuk
Copy link
Copy Markdown
Collaborator

@ppinchuk ppinchuk commented Mar 11, 2026

Fix issue with relative_to that couldn't resolve paths with a common ancestor a few folders up

@ppinchuk ppinchuk self-assigned this Mar 11, 2026
@ppinchuk ppinchuk requested a review from castelao as a code owner March 11, 2026 21:22
@ppinchuk ppinchuk added bugfix Fixed a known bug topic-python-general Issues/pull requests related to python p-high Priority: high labels Mar 11, 2026
Copilot AI review requested due to automatic review settings March 11, 2026 21:22
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Mar 11, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 54.49%. Comparing base (5698a48) to head (dbc58d1).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #391      +/-   ##
==========================================
- Coverage   54.52%   54.49%   -0.04%     
==========================================
  Files          61       61              
  Lines        5652     5652              
  Branches      530      530              
==========================================
- Hits         3082     3080       -2     
- Misses       2525     2526       +1     
- Partials       45       46       +1     
Flag Coverage Δ
unittests 54.49% <100.00%> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes save_run_meta() manifest path serialization so it can produce relative paths even when a target directory is not a descendant of dirs.out (e.g., sibling directories higher up the tree), addressing relate_to-style failures when the common ancestor is above dirs.out.

Changes:

  • Update manifest serialization to use Path.relative_to(..., walk_up=True) when writing meta.json.
  • Add unit tests covering sibling directories, multi-level walk-ups, nested output paths, and external directories.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File Description
compass/utilities/finalize.py Writes manifest paths using relative_to(..., walk_up=True) to support non-descendant targets.
tests/python/unit/utilities/test_utilities_finalize.py Adds test coverage for new manifest path behaviors across several directory topologies.

You can also share your feedback on Copilot code review. Take the survey.

@ppinchuk ppinchuk merged commit fc01226 into main Mar 11, 2026
18 checks passed
@ppinchuk ppinchuk deleted the pp/fix_dir_issue branch March 11, 2026 21:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bugfix Fixed a known bug p-high Priority: high topic-python-general Issues/pull requests related to python

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants