Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #390 +/- ##
=======================================
Coverage 54.52% 54.52%
=======================================
Files 61 61
Lines 5652 5652
Branches 530 530
=======================================
Hits 3082 3082
Misses 2525 2525
Partials 45 45
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes a bug in the Python processing pipeline where local file loader kwargs were sometimes accessed from an unprocessed (and not always dict-like) value, causing attribute errors. The update routes lookups through the already-configured loader kwargs to ensure consistent dictionary access.
Changes:
- Update
local_file_loader_kwargsto readpdf_read_kwargs/html_read_kwargsfrom the processedself.file_loader_kwargsdict. - Add
read_html_filesupport to the local file loader kwargs. - Minor Rust test-sample string formatting adjustment in qualitative ordinance sample output.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
crates/compass/src/scraper/ordinance/qualitative.rs |
Adjusts CSV header string formatting in the qualitative sample generator. |
compass/scripts/process.py |
Fixes local file loader kwargs lookup to use processed dict; adds read_html_file coroutine for local HTML reads. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We were previously pulling from the file kwargs tuple instead of the processed file loader kwargs, so sometimes we were getting an attribute error. Update behavior to pull fro mthe processed dict, so that we can always be sure it's a dictionary