Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make prediction column optional for performance estimation / calculation. #380

Merged
merged 4 commits into from
Apr 29, 2024

Conversation

nnansters
Copy link
Contributor

This PR makes the y_pred column name optional for realised and estimated performance calculators in binary classification problem types.

When no y_pred column is given, only AUROC and average precision are allowed as metric values.

@nnansters nnansters requested a review from nikml as a code owner April 28, 2024 21:31
Copy link

codecov bot commented Apr 28, 2024

Codecov Report

Attention: Patch coverage is 95.83333% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 78.58%. Comparing base (e98cab9) to head (b6d8bdf).

Files Patch % Lines
nannyml/performance_calculation/calculator.py 87.50% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #380      +/-   ##
==========================================
+ Coverage   78.41%   78.58%   +0.16%     
==========================================
  Files         110      110              
  Lines        8520     8540      +20     
  Branches     1514     1522       +8     
==========================================
+ Hits         6681     6711      +30     
+ Misses       1476     1465      -11     
- Partials      363      364       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nnansters nnansters merged commit a52c06d into main Apr 29, 2024
7 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant