Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Missing Values Handling #378

Merged
merged 29 commits into from
May 7, 2024
Merged

Update Missing Values Handling #378

merged 29 commits into from
May 7, 2024

Conversation

nikml
Copy link
Contributor

@nikml nikml commented Apr 22, 2024

No description provided.

@nikml nikml requested a review from nnansters as a code owner April 22, 2024 12:36
Copy link

codecov bot commented Apr 22, 2024

Codecov Report

Attention: Patch coverage is 63.71528% with 418 lines in your changes are missing coverage. Please review.

Project coverage is 76.48%. Comparing base (9f09409) to head (f30e875).

Files Patch % Lines
...performance_estimation/confidence_based/metrics.py 61.46% 167 Missing and 85 partials ⚠️
...e_calculation/metrics/multiclass_classification.py 60.13% 36 Missing and 21 partials ⚠️
...nyml/performance_calculation/metrics/regression.py 44.18% 30 Missing and 18 partials ⚠️
...mance_estimation/direct_loss_estimation/metrics.py 59.25% 15 Missing and 18 partials ⚠️
...mance_calculation/metrics/binary_classification.py 87.34% 11 Missing and 10 partials ⚠️
...ml/performance_estimation/confidence_based/cbpe.py 16.66% 2 Missing and 3 partials ⚠️
nannyml/base.py 75.00% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #378      +/-   ##
==========================================
- Coverage   78.60%   76.48%   -2.12%     
==========================================
  Files         110      110              
  Lines        8567     9221     +654     
  Branches     1519     1650     +131     
==========================================
+ Hits         6734     7053     +319     
- Misses       1474     1701     +227     
- Partials      359      467     +108     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

# Conflicts:
#	nannyml/performance_calculation/metrics/binary_classification.py
#	nannyml/performance_calculation/metrics/multiclass_classification.py
#	nannyml/performance_calculation/metrics/regression.py
#	nannyml/performance_estimation/confidence_based/cbpe.py
#	nannyml/performance_estimation/confidence_based/metrics.py
@nnansters nnansters merged commit a213cd3 into main May 7, 2024
5 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants