Skip to content
This repository has been archived by the owner on Jan 24, 2021. It is now read-only.

Backport #2512 to 1.x-WorkingBranch #2616

Open
wants to merge 2 commits into
base: 1.x-WorkingBranch
Choose a base branch
from

Conversation

danbarua
Copy link
Contributor

Prerequisites

  • I have written a descriptive pull-request title
  • I have verified that there are no overlapping pull-requests open
  • I have verified that I am following the Nancy code style guidelines
  • I have provided test coverage for my change (where applicable)
    ^ not covered by tests in this branch

Description

Replaces references to RequestStream with base Stream so that it can be swapped with another implementation eg. Microsof.IO.RecyclableMemoryStream

This will allow us to fix our production issues without upgrading to Nancy 2.x and give us some tracing, hopefully we will be able to pin down where the leaking TempFiles issue is coming from.

…emp files if .Dispose() not explicitly called. (NancyFx#2430)

# Conflicts:
#	src/Nancy/IO/RequestStream.cs
Allows swapping out switchover stream behaviour

Backport of NancyFx#2512
@danbarua
Copy link
Contributor Author

Build failure does not seem related to this PR.

Runner failure: System.MissingMethodException: Constructor on type 'Machine.Specifications.Runner.Impl.DefaultRunner' not found.

@khellang
Copy link
Member

khellang commented Dec 30, 2016

@danbarua Want to rebase this? Just so we can see if it fixes the build.

@khellang khellang mentioned this pull request Dec 30, 2016
4 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants