Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use correct language codes #2869

Draft
wants to merge 1 commit into
base: v2
Choose a base branch
from
Draft

Use correct language codes #2869

wants to merge 1 commit into from

Conversation

Derkades
Copy link
Member

@Derkades Derkades commented Jun 15, 2022

I think it makes more sense to use the standard codes for traditional and simplified Chinese rather than zh_TW (taiwan?) for traditional and zh_CN (china?) for simplified. I say that as someone who knows nothing about the Chinese language. Weblate seems to use Hans/Hant as well.

Could someone help with the migrations

@Derkades Derkades marked this pull request as draft June 15, 2022 19:53
@tadhgboyle
Copy link
Member

tadhgboyle commented Jun 15, 2022

This makes sense to do, but I think we should do it in 2.1.0.
I don't want any risks of further breaking changes for users quite yet, pre13 was quite rough 😬
What do you think?

@ichenglin
Copy link
Contributor

ichenglin commented Jun 16, 2022

It does make sense if you guys are not aiming for regional based translations.

The reason in which language codes zh_TW and zh_CN are usually referred to distinguish Traditional and Simplified is because they hold the greatest population. However, there are still some minor regional differences in the version of Chinese used by different countries.

Traditional Chinese:

  • zh_TW (Taiwan)
  • zh_HK (Hong Kong)
  • zh_MO (Macau)

Simplified Chinese:

  • zh_CN (Mainland China)
  • zh_SG (Singapore)

@Derkades
Copy link
Member Author

Thank you for the clarification, it makes sense now. Ideally we'd have all variants, but just Hans and Hant should be fine to reduce work for translators?

@ichenglin
Copy link
Contributor

ichenglin commented Jun 17, 2022

Hans and Hant would work out for most cases as the major difference is the characters used, while slight differences such as vocabulary shouldn't be hard to interpret. To be honest, most Chinese readers know how to read both Traditional and Simplified characters, so it's mostly just about preference.

Reducing to Hans and Hant sure would reduce work for translators, while there's not really much negative impact on users' experience.

@PikaMug
Copy link
Contributor

PikaMug commented Jun 19, 2022

Go with whatever the platform prefers. As a Crowdin user, zh-TW was the default (and is what Minecraft uses) and has wider adoptation, but zh-Hant does seem to have advantages. Neither is particularly stellar, though, at least in the eyes of the consortium https://www.w3.org/International/articles/bcp47/#script

@Derkades Derkades added this to the 2.1.0 milestone Nov 30, 2022
@Derkades Derkades removed this from the 2.1.0 milestone Apr 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants