Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Included limitations #211

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

IgnorantSapient
Copy link

Spent 5 hours trying to mock standalone functions using ts.

Spent  5 hours trying to mock standalone functions using ts.
@codecov-commenter
Copy link

codecov-commenter commented May 4, 2021

Codecov Report

Merging #211 (6f0a60b) into master (6637048) will increase coverage by 0.67%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #211      +/-   ##
==========================================
+ Coverage   93.55%   94.23%   +0.67%     
==========================================
  Files          34       34              
  Lines         652      659       +7     
  Branches       80       80              
==========================================
+ Hits          610      621      +11     
- Misses         30       33       +3     
+ Partials       12        5       -7     
Impacted Files Coverage Δ
src/utils/MockableFunctionsFinder.ts 91.66% <0.00%> (-8.34%) ⬇️
src/MethodStubSetter.ts 84.00% <0.00%> (ø)
src/MethodStubVerificator.ts 100.00% <0.00%> (ø)
src/utils/MethodCallToStringConverter.ts 100.00% <0.00%> (ø)
src/Mock.ts 95.77% <0.00%> (+1.40%) ⬆️
src/Spy.ts 86.11% <0.00%> (+5.55%) ⬆️
src/matcher/type/ObjectContainingMatcher.ts 100.00% <0.00%> (+10.00%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6637048...6f0a60b. Read the comment docs.

@cspotcode
Copy link

typeof is a reserved word. Even if there is a way to name a function typeof (is there?) I would not use it as an example in documentation.

@IgnorantSapient
Copy link
Author

@NagRock Its been more than a year since this small readme change was proposed, any reason as to why this shouldn't be merged? 🤔

@cspotcode
Copy link

Looks like the review feedback from a year ago was only addressed 10 minutes ago.

Also might wanna take a look at #183

@IgnorantSapient
Copy link
Author

@cspotcode this library has ~150,000 weekly downloads. Sad to see it not getting the attention it deserves. Maybe the @mockitoguy should adopt this.

@cspotcode
Copy link

Check out relevant discussion in #183. Lots of community voices appeared to be opposed to realistic forms of adoption.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants