Fixing static_vector memory leak in validatePipelineBindingLayouts #55
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DeviceWrapper::validatePipelineBindingLayouts will leak memory allocated for bindingsPerLayout & duplicatesPerLayout's members due to the way static_vector's resize is implemented, which assumes that all std::array's elements are in an uninitialized state by default. Changing static_vector to use assignment in resize instead of placement new/delete fixes the issue without adding a bunch of extra plumbing or running the destructor over each element in static_vector's constructor.
|
CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅ |
|
I have read the CLA Document and I hereby sign the CLA |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DeviceWrapper::validatePipelineBindingLayouts will leak memory allocated for bindingsPerLayout & duplicatesPerLayout's members due to the way static_vector's resize is implemented, which assumes that all std::array's elements are in an uninitialized state by default.
Changing static_vector to use assignment in resize instead of placement new/delete fixes the issue without adding a bunch of extra plumbing or running the destructor over each element in static_vector's constructor.