Update camera_ray_tracing.py: fix small bugs #726
Conversation
Fix the following 2 bugs: 1. 'CameraFOV' cannot be imported from kaolin.render.camera, but should be from kaolin.render.camera.intrinstics instead. 2. 'width' and 'height' of the generated pixel grid and camera should be consistent, otherwise the average of generated ray_dir does not equal to the desired look_at direction
| @@ -6,7 +6,8 @@ | |||
| import torch | |||
| import numpy as np | |||
| from typing import Tuple | |||
| from kaolin.render.camera import Camera, CameraFOV | |||
| from kaolin.render.camera import Camera | |||
| from kaolin.render.camera.intrinsics import CameraFOV | |||
There was a problem hiding this comment.
This one isn't actually needed as __init__.py has:
from .intrinsics import *| @@ -45,20 +46,21 @@ def generate_perspective_rays(camera: Camera, pixel_grid: Tuple[torch.Tensor, to | |||
|
|
|||
| return ray_orig, ray_dir, camera.near, camera.far | |||
|
|
|||
|
|
|||
| img_width = 200 | |||
| img_height =200 | |||
There was a problem hiding this comment.
Minor: Please fix the space here
| near=1e-2, far=1e2, | ||
| dtype=torch.float64, | ||
| device='cuda' | ||
| ) | ||
|
|
||
| pixel_grid = generate_pixel_grid(200, 200) | ||
| pixel_grid = generate_pixel_grid(img_width, img_height) |
There was a problem hiding this comment.
Given that this snippet should be a simple recipe, I agree with your suggestion of having the raygen grid and image plane with the same resolution.
To complete the picture however - the raygen grid resolution and image plane resolution can actually differ, and this can also be exploited to, i.e., trace a lower-resolution image.
For reference, kaolin-wisp implements exactly that for its interactive mode:
- https://github.com/NVIDIAGameWorks/kaolin-wisp/blob/main/wisp/renderer/core/render_core.py#L167C9-L167C9
- https://github.com/NVIDIAGameWorks/kaolin-wisp/blob/main/wisp/renderer/core/render_core.py#L290
Picking an arbitrary resolution (which is not a power of 2 downscale factor) can indeed cause alignment issues, which I think it what you're worried about?
Fix the following 2 bugs: