Add voxel_range option for mesh to voxel conversion #292
+17
−5
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, thank you for the work.
Some meshes cannot be voxelized unless normalize=True.
The ShapeNet_Voxels class also raises an error with some data.
kaolin/kaolin/datasets/shapenet.py
Line 409 in ec193ff
For example, this object cannot be voxelized.
http://shapenet.cs.stanford.edu/shapenet/obj-zip/ShapeNetCore.v1/04379243/10657fcfce1d326b30bbd4cddd04c77b/model.obj
The maximum value of this mesh is 0.5718, and when it is moved by the offset, it becomes 1.0718.
Since the range of voxelization is 0 to 1, an error occurs due to overflow.
This PR solved this problem by expanding voxel_range.