Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove tensorflow1.x dependency #434

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Remove tensorflow1.x dependency #434

wants to merge 3 commits into from

Conversation

carankt
Copy link

@carankt carankt commented Dec 16, 2020

Hey,
I have made the following changes, which helped me work better with the repository. Hoping it would do the same for others.

  • Removed the tensorflow1.x dependency
  • Created a .yaml config file in place of the hparams.py file
  • implemented the changes for training and inference code

Best,
KT

@carankt carankt changed the title Remove tensorflow1.x version dependency Remove tensorflow1.x dependency Dec 16, 2020
@lgtm-com
Copy link

lgtm-com bot commented Dec 16, 2020

This pull request introduces 2 alerts when merging 9f285fe into 185cd24 - view on LGTM.com

new alerts:

  • 1 for Missing call to __init__ during object initialization
  • 1 for First argument to super() is not enclosing class

sabard
sabard reviewed Dec 20, 2022
View reviewed changes
requirements.txt
@@ -1,5 +1,4 @@
matplotlib==2.1.0
tensorflow==1.15.2
numpy==1.13.3
inflect==0.2.5
librosa==0.6.0
Copy link

@sabard sabard Dec 20, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pyyaml package is also required here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sabard sabard sabard left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@carankt @sabard