Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update spark400 version to 4.0.1-SNAPSHOT #12288

Merged
merged 4 commits into from
Mar 7, 2025

Conversation

nartal1
Copy link
Collaborator

@nartal1 nartal1 commented Mar 6, 2025

This PR is to update spark400 version to 4.0.1-SNAPSHOT.
The release candidate(s) for Apache Spark-4.0 will be cut from 4.0.1-SNAPSHOT since the pom file in Apache Spark's branch-4.0 is updated to 4.0.1-SNAPSHOT.

Signed-off-by: Niranjan Artal <[email protected]>
@nartal1 nartal1 added the build Related to CI / CD or cleanly building label Mar 6, 2025
@nartal1 nartal1 self-assigned this Mar 6, 2025
@nartal1 nartal1 requested a review from a team as a code owner March 6, 2025 22:27
@nartal1
Copy link
Collaborator Author

nartal1 commented Mar 6, 2025

build

@nartal1
Copy link
Collaborator Author

nartal1 commented Mar 6, 2025

The initial CI failure was because this PR was not upmerged to latest branch and it missed updating the supportedExprs.csv for 355 shim - #12178

@nartal1
Copy link
Collaborator Author

nartal1 commented Mar 6, 2025

build

@nartal1
Copy link
Collaborator Author

nartal1 commented Mar 7, 2025

build

@nartal1
Copy link
Collaborator Author

nartal1 commented Mar 7, 2025

I included the missing supported ops in this PR. If the preference is to create a separate PR for that update, I can split this PR and keep this one for spark version update.

@gerashegalov
Copy link
Collaborator

I think the supported ops should be a separate PR. It would also be great to get some analysis why adding a shim can go in without adding those files

@nartal1
Copy link
Collaborator Author

nartal1 commented Mar 7, 2025

build

@nartal1
Copy link
Collaborator Author

nartal1 commented Mar 7, 2025

I think the supported ops should be a separate PR. It would also be great to get some analysis why adding a shim can go in without adding those files

Thanks! Created and merged a separate PR-#12290

@nartal1 nartal1 merged commit 7e4ae61 into NVIDIA:branch-25.04 Mar 7, 2025
53 of 54 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build Related to CI / CD or cleanly building
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants