Add Limited Read Support for Deletion Vectors on Databricks 14.3 [databricks] #12238
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
razajafri
force-pushed
the
SP-10661-db-14.3-deletion-vectors-perfile
branch
from
483b309 to
599498e
Compare
Signed-off-by: Raza Jafri <[email protected]>
razajafri
force-pushed
the
SP-10661-db-14.3-deletion-vectors-perfile
branch
from
599498e to
221abdb
Compare
revans2
reviewed
Mar 3, 2025
| * limitations under the License. | ||
| */ | ||
|
|
||
| package com.databricks.sql.transaction.tahoe.rapids |
There was a problem hiding this comment.
So is the plan to add this back in later? Or is this really gone gone?
| @delta_lake | ||
| @ignore_order | ||
| @pytest.mark.skipif(not supports_delta_lake_deletion_vectors(), \ | ||
| reason="Deletion vectors new in Delta Lake 2.4 / Apache Spark 3.4") |
There was a problem hiding this comment.
This is not 100% accurate.
https://docs.delta.io/latest/delta-deletion-vectors.html
Do we want to distinguish between the different operators being supported? I am fine with 2.4 being the base for support because scan with nothing that can write them is not really a supported feature we can test.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds read-support for deletion vectors on Databricks 14.3 when the
spark.rapids.sql.format.parquet.reader.typeis set toPERFILE.The
spark.rapids.sql.format.parquet.reader.typedefaults toPERFILEon Databricks 14.3 if the user doesn't set a preferred value.