Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Workaround: Exclude cudf_log.txt in RAT check #11870

Merged
merged 1 commit into from
Dec 13, 2024
Merged

Workaround: Exclude cudf_log.txt in RAT check #11870

merged 1 commit into from
Dec 13, 2024

Conversation

pxLi
Copy link
Collaborator

@pxLi pxLi commented Dec 13, 2024 •
edited
Loading 

Printing headers for text files without a valid license header...
=====================================================
== File: /home/jenkins/agent/workspace/jenkins-rapids_premerge-github-10377/sql-plugin/cudf_log.txt

Currently the output of cudf logger is failing blossom-ci,
try exclude it from the repo to unblock CI for now before we have an actual fix in JNI side

@pxLi pxLi added bug Something isn't working build Related to CI / CD or cleanly building labels Dec 13, 2024
@pxLi pxLi requested a review from abellina December 13, 2024 07:12
@pxLi pxLi self-assigned this Dec 13, 2024
@pxLi pxLi marked this pull request as draft December 13, 2024 07:15
@pxLi pxLi force-pushed the rat-exclude-cudf_log branch from aa5485d to 33a15e8 Compare December 13, 2024 07:17
@pxLi pxLi force-pushed the rat-exclude-cudf_log branch from 33a15e8 to c2106ca Compare December 13, 2024 07:26
@pxLi
Copy link
Collaborator Author

pxLi commented Dec 13, 2024 •
edited
Loading

build - please disregard my force push before any reviews, thanks

@pxLi pxLi marked this pull request as ready for review December 13, 2024 07:31
@abellina abellina merged commit 561068c into NVIDIA:branch-25.02 Dec 13, 2024
50 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abellina abellina abellina approved these changes

@jlowe jlowe jlowe approved these changes

@revans2 revans2 Awaiting requested review from revans2 revans2 is a code owner

@tgravescs tgravescs Awaiting requested review from tgravescs tgravescs is a code owner

@GaryShen2008 GaryShen2008 Awaiting requested review from GaryShen2008 GaryShen2008 is a code owner

@NvTimLiu NvTimLiu Awaiting requested review from NvTimLiu NvTimLiu is a code owner

@gerashegalov gerashegalov Awaiting requested review from gerashegalov gerashegalov is a code owner

Assignees

@pxLi pxLi

Labels
bug Something isn't working build Related to CI / CD or cleanly building
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pxLi @jlowe @abellina