Generate the CHANGELOG based on the PR's target branch [skip ci] #11867
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To fix: NVIDIA#11866 Generate the CHANGELOG based on the PR's target branch if the PR's project roadmap is empty. Signed-off-by: Tim Liu <[email protected]>
NvTimLiu
requested review from
jlowe,
gerashegalov,
revans2,
GaryShen2008,
yinqingh and
YanxuanLiu
YanxuanLiu
reviewed
Dec 12, 2024
We won't need the 'no_project_prs' variable because PRs will be added to the CHANGELOG. Signed-off-by: Tim Liu <[email protected]>
updated, remove the unused varaible |
pxLi
previously approved these changes
Dec 13, 2024
pxLi
reviewed
Dec 13, 2024
| project = f"{RELEASE} {ver}" | ||
| else: | ||
| continue | ||
| else: |
There was a problem hiding this comment.
nit: this should be safe to be removed, as it was trying make the script compatible for classic projects which had been gone for a long time. its also fine we could still leave it here
There was a problem hiding this comment.
Agree; removing compatibility with project cards simplifies the logic."
Yes verified PRs/Issues both with and without project[roadmap], works well |
it is no longer necessary to maintain compatibility with the old version of GitHub Projects Signed-off-by: Tim Liu <[email protected]>
|
Build PASS: |
pxLi
approved these changes
Dec 13, 2024
|
build |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To fix: #11866
Generate the CHANGELOG based on the PR's target branch if the PR's project roadmap is empty.