Async write support for ORC #11865
Open
Async write support for ORC #11865
+38
−10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jihoonson
force-pushed
the
async-orc-write
branch
from
8d4a241 to
3b01026
Compare
|
build |
|
build |
Signed-off-by: Jihoon Son <[email protected]>
jihoonson
force-pushed
the
async-orc-write
branch
from
99d0c24 to
a4b1f65
Compare
|
build |
abellina
reviewed
Dec 18, 2024
|
Any indication that this is a performance improvement for Orc? I assume so, but asking if you have data. |
mythrocks
reviewed
Dec 18, 2024
mythrocks
reviewed
Dec 18, 2024
@abellina I haven't run any performance test yet, but agree it will be useful. Unfortunately, I'm quite stuck in other work right now. Do you mind if I run some benchmark later and post the results here? |
|
build |
jihoonson
commented
Dec 19, 2024
| gen_list = [('_c' + str(i), gen) for i, gen in enumerate(orc_gen)] | ||
| assert_gpu_and_cpu_writes_are_equal_collect( | ||
| lambda spark, path: gen_df(spark, gen_list, length=num_rows).write.orc(path), | ||
| lambda spark, path: spark.read.orc(path).orderBy([('_c' + str(i)) for i in range(num_cols)]), |
There was a problem hiding this comment.
It seems that the GPU and CPU orc readers can return the same rows in different orders. Added an orderBy to make the test deterministic.
There was a problem hiding this comment.
nit: we have @ignore_order marker for this
|
build |
|
The test failure is filed in #11897. |
|
build |
abellina
approved these changes
Dec 20, 2024
revans2
approved these changes
Dec 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up to #11730.
This PR adds the async write support for the ORC format as well as an integration test for it. This PR is marked as a draft since it depends on #11855.