Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix build error due to changing the signature of cudf Table.readJSON #11655

Draft
wants to merge 1 commit into
base: branch-25.02
Choose a base branch
from
Draft

Fix build error due to changing the signature of cudf Table.readJSON #11655

wants to merge 1 commit into from

Conversation

ttnghia
Copy link
Collaborator

@ttnghia ttnghia commented Oct 25, 2024

This fixes plugin build which breaks due to rewriting Java API Table.readJSON to return the output from libcudf read_json directly (rapidsai/cudf#17180).

Depends on:

Partially contributes to #11560.

@ttnghia ttnghia added task Work required that improves the product but is not user facing cudf_dependency An issue or PR with this label depends on a new feature in cudf labels Oct 25, 2024
@ttnghia ttnghia requested a review from revans2 October 25, 2024 05:03
@ttnghia ttnghia self-assigned this Oct 25, 2024
@ttnghia ttnghia marked this pull request as draft October 25, 2024 05:03
revans2
revans2 reviewed Oct 25, 2024
View reviewed changes
Copy link
Collaborator

@revans2 revans2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There were a lot more changes that went into this that I think we probably want to revert beyond just removing the parameters.

#11464

Specifically the changes to the scala code and not the tests.

@ttnghia ttnghia changed the base branch from branch-24.12 to branch-25.02 December 12, 2024 17:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@revans2 revans2 revans2 left review comments

At least 1 approving review is required to merge this pull request.

Assignees

@ttnghia ttnghia

Labels
cudf_dependency An issue or PR with this label depends on a new feature in cudf task Work required that improves the product but is not user facing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ttnghia @revans2