address comments

Signed-off-by: Hongbin Ma (Mahone) <[email protected]>
NVIDIA · Dec 10, 2024 · af093a6 · af093a6
1 parent 783cd27
commit af093a6
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/sql-plugin/src/main/scala/com/nvidia/spark/rapids/GpuSemaphore.scala b/sql-plugin/src/main/scala/com/nvidia/spark/rapids/GpuSemaphore.scala
@@ -321,7 +321,7 @@ private final class SemaphoreTaskInfo(val stageId: Int, val taskAttemptId: Long)
       semaphore.release(numPermits)
       hasSemaphore = false
       lastReleased = System.nanoTime()
-      GpuTaskMetrics.get.addGpuTime(lastReleased - lastAcquired)
+      GpuTaskMetrics.get.addSemaphoreHoldingTime(lastReleased - lastAcquired)
       nvtxRange.foreach(_.close())
       nvtxRange = None
     }

diff --git a/sql-plugin/src/main/scala/org/apache/spark/sql/rapids/GpuTaskMetrics.scala b/sql-plugin/src/main/scala/org/apache/spark/sql/rapids/GpuTaskMetrics.scala
@@ -183,7 +183,7 @@ class AvgLongAccumulator extends AccumulatorV2[jl.Long, jl.Double] {
 }
 
 class GpuTaskMetrics extends Serializable {
-  private val gpuTime = new NanoSecondAccumulator
+  private val semaphoreHoldingTime = new NanoSecondAccumulator
   private val semWaitTimeNs = new NanoSecondAccumulator
   private val retryCount = new LongAccumulator
   private val splitAndRetryCount = new LongAccumulator
@@ -239,7 +239,7 @@ class GpuTaskMetrics extends Serializable {
   }
 
   private val metrics = Map[String, AccumulatorV2[_, _]](
-    "gpuTime" -> gpuTime,
+    "gpuTime" -> semaphoreHoldingTime,
     "gpuSemaphoreWait" -> semWaitTimeNs,
     "gpuRetryCount" -> retryCount,
     "gpuSplitAndRetryCount" -> splitAndRetryCount,
@@ -290,7 +290,7 @@ class GpuTaskMetrics extends Serializable {
     }
   }
 
-  def addGpuTime(duration: Long): Unit = gpuTime.add(duration)
+  def addSemaphoreHoldingTime(duration: Long): Unit = semaphoreHoldingTime.add(duration)
 
   def getSemWaitTime(): Long = semWaitTimeNs.value.value