Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEA] AutoTuner should not skip non-gpu eventlogs #728

Merged
merged 2 commits into from
Jan 18, 2024
Merged

[FEA] AutoTuner should not skip non-gpu eventlogs #728

merged 2 commits into from
Jan 18, 2024

Conversation

amahussein
Copy link
Collaborator

Signed-off-by: Ahmed Hussein (amahussein) [email protected]

Fixes #726

  • The Autotuner can still make recommendation regardless of the GPU profile info
  • Changed the code to avoid Null objects. The Autotuner could throw a NPE when the user not supplying any eventlog.
  • Fixed the unit-tests accordingly
  • Tested the new changes running a CPU eventlog

@amahussein
[FEA] AutoTuner should not skip non-gpu eventlogs
06457dc 
Signed-off-by: Ahmed Hussein (amahussein) <[email protected]>

Fixes NVIDIA#726

- The Autotuner can still make recommendation regardless of the GPU
  profile info
- Changed the code to avoid Null objects. The Autotuner could throw a
  NPE when the user not supplying any eventlog.
- Fixed the unit-tests accordingly
- Tested the new changes running a CPU eventlog
@amahussein amahussein added feature request New feature or request core_tools Scope the core module (scala) labels Jan 16, 2024
@amahussein amahussein self-assigned this Jan 16, 2024
@amahussein
update copyrights
27d20a7 
Signed-off-by: Ahmed Hussein (amahussein) <[email protected]>
parthosa
parthosa approved these changes Jan 18, 2024
View reviewed changes
Copy link
Collaborator

@parthosa parthosa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @amahussein

@amahussein amahussein merged commit 2f1c7ee into NVIDIA:dev Jan 18, 2024
14 checks passed
@amahussein amahussein deleted the spark-rapids-tools-726 branch January 18, 2024 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@parthosa parthosa parthosa approved these changes

@kuhushukla kuhushukla Awaiting requested review from kuhushukla

@nartal1 nartal1 Awaiting requested review from nartal1

Assignees

@amahussein amahussein

Labels
core_tools Scope the core module (scala) feature request New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[FEA] AutoTuner should not skip non-gpu eventlogs
2 participants
@amahussein @parthosa