Generate an output file with runtime and build information #705
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ahmed Hussein (amahussein) <[email protected]> Fixes NVIDIA#699 This PR is to dump the runtime/build information of the tools jar to the output folder. By knowing which Tools version has been used and which Spark version has been used in the runtime, developers can have more insights about the output and the numbers generated by the Tools. For Qualification: - `rapids_4_spark_qualification_output/runtime.properties` For Profiling: - `rapids_4_spark_profile/runtime.properties` A sample of the generated file is as follows: Notice that - `runtime.spark.version` is the spark version loaded during runtime, while `build.spark.version` is the version used to build the tools jar. - `build.verion` represents the Tools jar version ``` build.hadoop.version=3.3.6 build.java.version=1.8.0_322 build.scala.version=2.12.15 build.spark.version=3.1.1 build.version=23.10.2-SNAPSHOT runtime.spark.version=3.3.3 ```
Signed-off-by: Ahmed Hussein (amahussein) <[email protected]>
amahussein
added
feature request
|
@viadea and @kuhushukla |
nartal1
reviewed
Jan 8, 2024
core/src/main/scala/org/apache/spark/sql/rapids/tool/util/RapidsToolsConfUtil.scala
Outdated
Show resolved
Hide resolved
core/src/main/scala/org/apache/spark/sql/rapids/tool/util/RuntimeReportGenerator.scala
Show resolved
Hide resolved
Signed-off-by: Ahmed Hussein (amahussein) <[email protected]>
Signed-off-by: Ahmed Hussein (amahussein) <[email protected]>
|
Thanks @nartal1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Ahmed Hussein (amahussein) [email protected]
Fixes #699
This PR is to dump the runtime/build information of the tools jar to the output folder. By knowing which Tools version has been used and which Spark version has been used in the runtime, developers can have more insights about the output and the numbers generated by the Tools.
For Qualification:
rapids_4_spark_qualification_output/runtime.propertiesFor Profiling:
rapids_4_spark_profile/runtime.propertiesA sample of the generated file is as follows:
Notice that
runtime.spark.versionis the spark version loaded during runtime, whilebuild.spark.versionis the version used to build the tools jar.build.verionrepresents the Tools jar version