Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update pom to fail on warnings #701

Merged
merged 1 commit into from
Dec 26, 2023

Conversation

amahussein
Copy link
Collaborator

Fixes #689

This PR is to add build flags to fail with

  • unused imports
  • unused variables / parameters
  • incorrect/unused match patterns

Fix all the problems in the existing code

Update pom to fail on warnings

Signed-off-by: Ahmed Hussein (amahussein) <[email protected]>
@amahussein amahussein added core_tools Scope the core module (scala) build labels Dec 26, 2023
@amahussein amahussein self-assigned this Dec 26, 2023
@amahussein amahussein merged commit 03effc2 into NVIDIA:dev Dec 26, 2023
10 checks passed
@amahussein amahussein deleted the spark-rapids-tools-689 branch December 26, 2023 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build core_tools Scope the core module (scala)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Github workflow should reject commits with warnings
2 participants