Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix user qualification tool runtime error in get_platform_name for onprem platform #684

Merged

Conversation

cindyyuanjiang
Copy link
Collaborator

@cindyyuanjiang cindyyuanjiang commented Dec 8, 2023

Fixes #683

Changes
We fix a bug in function get_platform_name definition for onprem platform. The original implementation could lead to referencing an unassigned variable.

Testing
For user qualification tool, we tested the following commands:

spark_rapids_user_tools onprem qualification --eventlogs <my-event-logs>
spark_rapids_user_tools onprem qualification --eventlogs <my-event-logs> --cpu_cluster <my-cpu-cluster-file>
spark_rapids_user_tools onprem qualification --eventlogs <my-event-logs> --cpu_cluster <my-cpu-cluster-file> --target_platform dataproc

For user profiling tool:

spark_rapids_user_tools onprem profiling --eventlogs <my-event-logs>

@cindyyuanjiang cindyyuanjiang self-assigned this Dec 8, 2023
@cindyyuanjiang cindyyuanjiang added bug Something isn't working user_tools Scope the wrapper module running CSP, QualX, and reports (python) labels Dec 8, 2023
Copy link
Collaborator

@parthosa parthosa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Collaborator

@nartal1 nartal1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @cindyyuanjiang !

@cindyyuanjiang cindyyuanjiang merged commit 9f60c9e into NVIDIA:dev Dec 9, 2023
10 checks passed
@cindyyuanjiang cindyyuanjiang deleted the fix-get-platform-name-onprem branch December 9, 2023 00:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working user_tools Scope the wrapper module running CSP, QualX, and reports (python)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] User qualification tool runtime error from get_platform_name for onprem platform
3 participants