Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updating new CLI name from ascli to spark_rapids #673

Merged
merged 1 commit into from
Nov 28, 2023
Merged

Updating new CLI name from ascli to spark_rapids #673

merged 1 commit into from
Nov 28, 2023

Conversation

mattahrens
Copy link
Collaborator

Changing new CLI from ascli to spark_rapids ahead of formal documentation updates to the new User Guide

@mattahrens mattahrens self-assigned this Nov 27, 2023
nartal1
nartal1 approved these changes Nov 27, 2023
View reviewed changes
Copy link
Collaborator

@nartal1 nartal1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. We don't have to make any changes in CI as we currently don't have any tests running with this commandline.

parthosa
parthosa approved these changes Nov 28, 2023
View reviewed changes
Copy link
Collaborator

@parthosa parthosa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @mattahrens.

@mattahrens mattahrens merged commit 88d420c into NVIDIA:dev Nov 28, 2023
9 checks passed
@mattahrens mattahrens deleted the update-cli-to-spark-rapids branch November 28, 2023 15:07
@parthosa parthosa added the user_tools Scope the wrapper module running CSP, QualX, and reports (python) label Nov 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nartal1 nartal1 nartal1 approved these changes

@cindyyuanjiang cindyyuanjiang cindyyuanjiang approved these changes

@parthosa parthosa parthosa approved these changes

Assignees

@mattahrens mattahrens

Labels
user_tools Scope the wrapper module running CSP, QualX, and reports (python)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mattahrens @parthosa @cindyyuanjiang @nartal1