Fix platform names as string constants and reduce redundancy in unit tests #667
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Partho Sarthi <[email protected]>
Signed-off-by: Partho Sarthi <[email protected]>
Signed-off-by: Partho Sarthi <[email protected]>
parthosa
force-pushed
the
spark-rapids-tools-666
branch
from
a30fc60 to
b94975c
Compare
core/src/main/scala/com/nvidia/spark/rapids/tool/Platform.scala
Outdated
Show resolved
Hide resolved
core/src/main/scala/com/nvidia/spark/rapids/tool/profiling/ProfileArgs.scala
Outdated
Show resolved
Hide resolved
core/src/main/scala/com/nvidia/spark/rapids/tool/qualification/QualificationArgs.scala
Outdated
Show resolved
Hide resolved
cindyyuanjiang
previously approved these changes
Nov 22, 2023
Signed-off-by: Partho Sarthi <[email protected]>
parthosa
dismissed stale reviews from cindyyuanjiang and nartal1
via
8533b52
nartal1
approved these changes
Nov 28, 2023
cindyyuanjiang
approved these changes
Nov 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #666. This PR improves robustness by removing hardcoded string values for platform names.
Changes:
Platform.scala.PlatformNames.DEFAULTthat should be used as default platform for all cases.