-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unified platform handling and fetching of operator score files #661
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Partho Sarthi <[email protected]>
Signed-off-by: Partho Sarthi <[email protected]>
parthosa
changed the title
Handle incorrect platform in core tools
Improve handling of string based platform types and operator score files
Nov 16, 2023
parthosa
changed the title
Improve handling of string based platform types and operator score files
Unified platform handling and enhanced operator score files
Nov 16, 2023
parthosa
requested review from
cindyyuanjiang,
mattahrens,
tgravescs,
kuhushukla and
nartal1
November 16, 2023 22:12
Signed-off-by: Partho Sarthi <[email protected]>
Signed-off-by: Partho Sarthi <[email protected]>
Signed-off-by: Partho Sarthi <[email protected]>
tgravescs
reviewed
Nov 16, 2023
core/src/main/scala/com/nvidia/spark/rapids/tool/Platform.scala
Outdated
Show resolved
Hide resolved
core/src/main/scala/com/nvidia/spark/rapids/tool/Platform.scala
Outdated
Show resolved
Hide resolved
core/src/main/scala/com/nvidia/spark/rapids/tool/Platform.scala
Outdated
Show resolved
Hide resolved
…mNames Signed-off-by: Partho Sarthi <[email protected]>
Signed-off-by: Partho Sarthi <[email protected]>
LGTM overall. Would it be right to say that the operator score changes here allow for filenames that tell us which platform they are for and not necessarily the score aspect of it? Thank you. |
tgravescs
approved these changes
Nov 20, 2023
parthosa
changed the title
Unified platform handling and enhanced operator score files
Unified platform handling and naming of operator score files
Nov 20, 2023
nartal1
approved these changes
Nov 20, 2023
parthosa
changed the title
Unified platform handling and naming of operator score files
Unified platform handling and fetching of operator score files
Nov 20, 2023
kuhushukla
approved these changes
Nov 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #616.
This PR fixes the below issues related to platform argument:
Major Changes:
Platform.scala
:Platform.scala
outside the profiler package for shared use.PlatformNames
to store platform strings as constants.PlatformFactory
to createPlatform
instances based on platform string values.Addresses #1
createInstance()
to get platform instance.Addresses #2
PluginTypeChecker.scala
:getOperatorScoreFile()
defined inPlatform.scala
for dynamic filename generation of operator score files.Addresses #3
Follow Up:
PlatformNames
class.