Updating dataproc container cost to be multiplied by number of cores #648
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: mattahrens <[email protected]>
mattahrens
added
the
user_tools
parthosa
requested changes
Nov 2, 2023
Signed-off-by: mattahrens <[email protected]>
mattahrens
commented
Nov 2, 2023
| @@ -306,12 +306,14 @@ def __calculate_dataproc_group_cost(self, cluster_inst: ClusterGetAccessor, node | |||
| if gpu_per_machine > 0: | |||
| gpu_unit_price = self.price_provider.get_gpu_price(gpu_type) | |||
| gpu_cost = gpu_unit_price * gpu_per_machine | |||
| return nodes_cnt * (cores_cost + memory_cost + gpu_cost) | |||
| return nodes_cnt * (cores_cost + memory_cost + dataproc_cost + gpu_cost) | |||
There was a problem hiding this comment.
Need to remove dataproc_cost reference here
Signed-off-by: mattahrens <[email protected]>
Signed-off-by: mattahrens <[email protected]>
Signed-off-by: mattahrens <[email protected]>
Signed-off-by: mattahrens <[email protected]>
Signed-off-by: mattahrens <[email protected]>
Signed-off-by: mattahrens <[email protected]>
parthosa
reviewed
Nov 3, 2023
user_tools/src/spark_rapids_pytools/pricing/dataproc_gke_pricing.py
Outdated
Show resolved
Hide resolved
parthosa
reviewed
Nov 3, 2023
Signed-off-by: mattahrens <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #607