Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Support autoscaling clusters for user qualification tool on Databricks platforms #647

Merged
merged 1 commit into from
Nov 3, 2023

Conversation

cindyyuanjiang
Copy link
Collaborator

Fixes #624

The issue was due to that the user qualification tool is unable to find the number of workers for autoscaling clusters on Databricks-AWS/Azure because the key num_workers does not exist in the cluster properties file. In this case, the tool defaults num_workers to 0, which leads to RuntimeError: Invalid cluster: The cluster has no worker nodes..

In this PR, we add logic to extract the number of workers from the autoscale information for Databricks AWS/Azure autoscaling clusters.

@cindyyuanjiang cindyyuanjiang self-assigned this Nov 2, 2023
@cindyyuanjiang cindyyuanjiang added bug Something isn't working user_tools Scope the wrapper module running CSP, QualX, and reports (python) labels Nov 2, 2023
Copy link
Collaborator

@nartal1 nartal1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Copy link
Collaborator

@parthosa parthosa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cindyyuanjiang cindyyuanjiang merged commit 2f1a9fb into NVIDIA:dev Nov 3, 2023
9 checks passed
@cindyyuanjiang cindyyuanjiang deleted the autoscale-worker-node branch November 3, 2023 17:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working user_tools Scope the wrapper module running CSP, QualX, and reports (python)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] User qualification tool does not support cluster properties file with autoscaling worker nodes
3 participants