Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add unit tests for Dataproc GKE with mock GKE cluster #618

Merged
merged 1 commit into from
Oct 17, 2023
Merged

Add unit tests for Dataproc GKE with mock GKE cluster #618

merged 1 commit into from
Oct 17, 2023

Conversation

parthosa
Copy link
Collaborator

@parthosa parthosa commented Oct 13, 2023 •
edited
Loading

Contributes to #253. This PR adds python unit tests for Dataproc GKE.

Changes:

  1. Added yaml config for a mock Dataproc GKE cluster.
  2. Implemented schema verification to distinguish between Dataproc GCE and GKE cluster.
  3. Added GKE as a CSP in unit tests.

@parthosa parthosa added the user_tools Scope the wrapper module running CSP, QualX, and reports (python) label Oct 13, 2023
@parthosa parthosa self-assigned this Oct 13, 2023
@parthosa parthosa mentioned this pull request Oct 13, 2023
Closed
@parthosa parthosa merged commit 10f289c into NVIDIA:dev Oct 17, 2023
9 checks passed
@parthosa parthosa deleted the spark-rapids-tools-253-gke-tests branch October 17, 2023 18:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nartal1 nartal1 nartal1 approved these changes

@cindyyuanjiang cindyyuanjiang cindyyuanjiang approved these changes

@mattahrens mattahrens Awaiting requested review from mattahrens

Assignees

@parthosa parthosa

Labels
user_tools Scope the wrapper module running CSP, QualX, and reports (python)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@parthosa @cindyyuanjiang @nartal1