Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEA] Add qualification user tool options to support external pricing #595

Merged

Conversation

cindyyuanjiang
Copy link
Collaborator

Fixes #489

We add two qualification user tool options to support external pricing in ascli:

  • --cpu_cluster_price: argument used to specify hourly CPU cluster cost
  • --estimated_gpu_cluster_price: argument used to specify hourly GPU cluster cost

Signed-off-by: cindyyuanjiang <[email protected]>
Signed-off-by: cindyyuanjiang <[email protected]>
Signed-off-by: cindyyuanjiang <[email protected]>
@cindyyuanjiang cindyyuanjiang self-assigned this Sep 27, 2023
@cindyyuanjiang cindyyuanjiang added feature request New feature or request user_tools Scope the wrapper module running CSP, QualX, and reports (python) labels Sep 27, 2023
@cindyyuanjiang
Copy link
Collaborator Author

cindyyuanjiang commented Sep 27, 2023

We tested the PR change with the following script:

export EVENT_LOGS=... # a local event log file
export PLATFORM=... # the csp platform we want to test
export CPU_CLUSTER_PROPS=... # the cpu cluster properties file for the relative platform
export CPU_CLUSTER_PRICE=... # hourly cpu cluster price for the csp platform
export GPU_CLUSTER_PRICE=... # hourly gpu cluster price for the csp platform

########################################
# running each of the CSP platforms
########################################

# run the following commands and confirm the pricing calculations are correct

ascli qualification \
  --platform $PLATFORM \
  --eventlogs $EVENT_LOGS \
  --cluster $CPU_CLUSTER_PROPS

ascli qualification \
  --platform $PLATFORM \
  --eventlogs $EVENT_LOGS \
  --cluster $CPU_CLUSTER_PROPS \
  --cpu_cluster_price $CPU_CLUSTER_PRICE

ascli qualification \
  --platform $PLATFORM \
  --eventlogs $EVENT_LOGS \
  --cluster $CPU_CLUSTER_PROPS \
  --cpu_cluster_price $CPU_CLUSTER_PRICE \
  --estimated_gpu_cluster_price $GPU_CLUSTER_PRICE

@cindyyuanjiang cindyyuanjiang added the new-cli scope out future new-cli work for the next few months label Sep 28, 2023
@cindyyuanjiang cindyyuanjiang merged commit da8f88f into NVIDIA:dev Sep 29, 2023
9 checks passed
@cindyyuanjiang cindyyuanjiang deleted the add-external-pricing-options branch September 29, 2023 01:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request New feature or request new-cli scope out future new-cli work for the next few months user_tools Scope the wrapper module running CSP, QualX, and reports (python)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEA] Add in qualification user tools option to support external pricing
2 participants