Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEA] Add flatten function as supported in qualification tool #587

Merged
merged 1 commit into from
Sep 26, 2023
Merged

[FEA] Add flatten function as supported in qualification tool #587

merged 1 commit into from
Sep 26, 2023

Conversation

cindyyuanjiang
Copy link
Collaborator

Fixes #586

Rapids-plugin added flatten function GPU support. We updated the tools to treat flatten as supported and added a unit test to verify it.

@cindyyuanjiang
added flatten as supported expr
915906c 
Signed-off-by: cindyyuanjiang <[email protected]>
@cindyyuanjiang cindyyuanjiang self-assigned this Sep 25, 2023
@cindyyuanjiang cindyyuanjiang added feature request New feature or request core_tools Scope the core module (scala) labels Sep 25, 2023
parthosa
parthosa approved these changes Sep 26, 2023
View reviewed changes
Copy link
Collaborator

@parthosa parthosa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @cindyyuanjiang. LGTM.

@cindyyuanjiang cindyyuanjiang merged commit 3610023 into NVIDIA:dev Sep 26, 2023
9 checks passed
@cindyyuanjiang cindyyuanjiang deleted the add-flatten-function branch September 26, 2023 18:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@parthosa parthosa parthosa approved these changes

@mattahrens mattahrens Awaiting requested review from mattahrens

Assignees

@cindyyuanjiang cindyyuanjiang

Labels
core_tools Scope the core module (scala) feature request New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[FEA] Qualification should treat flatten function as supported
2 participants
@cindyyuanjiang @parthosa