-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FEA] Add user qualification tool options for specifying pricing discounts for CPU or GPU cluster, or both #583
Conversation
… spark_rapids_user_tools Signed-off-by: cindyyuanjiang <[email protected]>
Signed-off-by: cindyyuanjiang <[email protected]>
Signed-off-by: cindyyuanjiang <[email protected]>
We tested the PR change with the following script:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @cindyyuanjiang! Just a nit to remove redundancy and better readability. Otherwise, LGTM.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @cindyyuanjiang. Added a few minor comments.
Signed-off-by: cindyyuanjiang <[email protected]>
Fixes #476
We add three new user qualification tool options (for both
spark_rapids_user_tools
andascli
CLI)--cpu_discount
: the specified percentage discount for the CPU cluster cost to be reduced by (e.g. 30 for 30% discount)--gpu_discount
: the specified percentage discount for the GPU cluster cost to be reduced by--global_discount
: the specified percentage discount for both cluster costs to be reduced by. Note that if--global_discount
is specified, neither--cpu_discount
nor--gpu_discount
should be specified, otherwise the tool will raise an exceptionFollow up work:
We need to update documentation, issue tracked here: #584