Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Qualification tool: Invalid --platform doesn't error #616

Closed
tgravescs opened this issue Oct 13, 2023 · 2 comments · Fixed by #661
Closed

[BUG] Qualification tool: Invalid --platform doesn't error #616

tgravescs opened this issue Oct 13, 2023 · 2 comments · Fixed by #661
Assignees
Labels
bug Something isn't working core_tools Scope the core module (scala) user_tools Scope the wrapper module running CSP, QualX, and reports (python)

Comments

@tgravescs
Copy link
Collaborator

Describe the bug
Passing an invalid or not supported platform doesn't error. This can lead to user getting results they don't expect.

ie: --platform gcp or --platform data-t4fdsfd

@tgravescs tgravescs added bug Something isn't working ? - Needs Triage labels Oct 13, 2023
@parthosa
Copy link
Collaborator

parthosa commented Oct 17, 2023

In addition to this, the platform types in user tools do not match platform types in core tools. Platform types in core tools -support gpu options (eg, dataproc-t4, emr-t4, emr-a10 etc) where as user tools takes only CSP names as platform (eg, dataproc, emr).

Because of this, we are not leveraging the custom speedup factors generated for different GPU types.

While passing the platform value from user tools to core tools. we should append the gpu type.

@mattahrens mattahrens added core_tools Scope the core module (scala) user_tools Scope the wrapper module running CSP, QualX, and reports (python) and removed ? - Needs Triage labels Oct 18, 2023
@kuhushukla
Copy link
Collaborator

kuhushukla commented Nov 13, 2023

This issue exists in the profiling tool options as well where we should also try and create parity with what names we use in the user-tools and the jar versions to avoid more match case statements and chances of error. The example that brought me to this error was for databricks-azure

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working core_tools Scope the core module (scala) user_tools Scope the wrapper module running CSP, QualX, and reports (python)
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants