Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEA] Qualification tool - enhance exec to stage mapping #615

Closed
tgravescs opened this issue Oct 12, 2023 · 1 comment · Fixed by #634
Closed

[FEA] Qualification tool - enhance exec to stage mapping #615

tgravescs opened this issue Oct 12, 2023 · 1 comment · Fixed by #634
Assignees
Labels
core_tools Scope the core module (scala) feature request New feature or request

Comments

@tgravescs
Copy link
Collaborator

tgravescs commented Oct 12, 2023

Is your feature request related to a problem? Please describe.
Currently if we can't map an exec to a stage, it falls into a general bucket where we map it into any stages left. This can obviously be inaccurate. The problem is we map execs to stages based on the metrics and not all execs have metrics that allow us to map.

perhaps we can change our algorithm to look at the execs around execs without stages to say that if the one before and after it are in a stage then this one is likely in that same stage.

@tgravescs
Copy link
Collaborator Author

Note this could have more effect now that we are looking more at adding transition times. If an exec isn't mapped and its one that fell back to CPU it has potential to affect that stages overall time more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core_tools Scope the core module (scala) feature request New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants