Skip to content

Commit

Permalink
address review comments
Browse files Browse the repository at this point in the history
  • Loading branch information
nartal1 committed Nov 17, 2023
1 parent 1ed89d7 commit e65c989
Show file tree
Hide file tree
Showing 2 changed files with 11 additions and 11 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -318,16 +318,16 @@ object SQLMetricsStats {
}

object IgnoreExecs {
val AdaptiveSparkPlan = "AdaptiveSparkPlan" // AdaptiveSparkPlan is not a real exec. It is
// a wrapper for the whole plan.
val CollectLimit = "CollectLimit" // Collect Limit replacement can be slower on the
// GPU. Disabled by default.
val ScanExistingRDD = "Scan ExistingRDD"
val ExecuteCreateViewCommand = "Execute CreateViewCommand"
val ExistingRDD = "ExistingRDD"
val LocalTableScan = "LocalTableScan"

def getallIgnoreExecs = Set(AdaptiveSparkPlan, CollectLimit, ScanExistingRDD,
// AdaptiveSparkPlan is not a real exec. It is a wrapper for the whole plan.
private val AdaptiveSparkPlan = "AdaptiveSparkPlan"
// Collect Limit replacement can be slower on the GPU. Disabled by default.
private val CollectLimit = "CollectLimit"
private val ScanExistingRDD = "Scan ExistingRDD"
private val ExecuteCreateViewCommand = "Execute CreateViewCommand"
private val ExistingRDD = "ExistingRDD"
private val LocalTableScan = "LocalTableScan"

def getAllIgnoreExecs: Set[String] = Set(AdaptiveSparkPlan, CollectLimit, ScanExistingRDD,
ExecuteCreateViewCommand, ExistingRDD, LocalTableScan)
}

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -587,7 +587,7 @@ class QualificationAppInfo(
}.flatten
topLevelExecs ++ childrenExecs
}.collect {
case x if !IgnoreExecs.getallIgnoreExecs.contains(x.exec) => x.exec
case x if !IgnoreExecs.getAllIgnoreExecs.contains(x.exec) => x.exec
}.toSet.mkString(";").trim.replaceAll("\n", "").replace(",", ":")


Expand Down

0 comments on commit e65c989

Please sign in to comment.