Skip to content

Commit

Permalink
Improve platform names in documentation
Browse files Browse the repository at this point in the history
Signed-off-by: Partho Sarthi <[email protected]>
  • Loading branch information
parthosa committed Nov 16, 2023
1 parent a7f3c74 commit ddf3aa4
Show file tree
Hide file tree
Showing 3 changed files with 10 additions and 6 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,11 @@ object PlatformTypes {
val EMR_A10 = "emr-a10"
val EMR_T4 = "emr-t4"
val ONPREM = "onprem"

def getAllPlatformNames: List[String] = List(
DATABRICKS_AWS, DATABRICKS_AZURE, DATAPROC, DATAPROC_GKE_L4, DATAPROC_GKE_T4,
DATAPROC_L4, DATAPROC_SL_L4, DATAPROC_T4, EMR, EMR_A10, EMR_T4, ONPREM
)
}

/**
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@
*/
package com.nvidia.spark.rapids.tool.profiling

import com.nvidia.spark.rapids.tool.PlatformTypes
import org.rogach.scallop.{ScallopConf, ScallopOption}
import org.rogach.scallop.exceptions.ScallopException

Expand Down Expand Up @@ -67,9 +68,7 @@ Usage: java -cp rapids-4-spark-tools_2.12-<version>.jar:$SPARK_HOME/jars/*
val platform: ScallopOption[String] =
opt[String](required = false,
descr = "Cluster platform where Spark GPU workloads were executed. Options include " +
"onprem, dataproc-t4, dataproc-l4, dataproc-serverless-l4, dataproc-gke-t4, " +
"dataproc-gke-l4, emr-t4, emr-a10, databricks-aws, and databricks-azure. Default " +
"is onprem.",
s"${PlatformTypes.getAllPlatformNames.mkString(", ")}. Default is ${PlatformTypes.ONPREM}.",
default = Some(Profiler.DEFAULT_PLATFORM))
val generateTimeline: ScallopOption[Boolean] =
opt[Boolean](required = false,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,8 @@
*/
package com.nvidia.spark.rapids.tool.qualification

import com.nvidia.spark.rapids.tool.PlatformTypes

import org.rogach.scallop.{ScallopConf, ScallopOption}
import org.rogach.scallop.exceptions.ScallopException

Expand Down Expand Up @@ -155,9 +157,7 @@ Usage: java -cp rapids-4-spark-tools_2.12-<version>.jar:$SPARK_HOME/jars/*
val platform: ScallopOption[String] =
opt[String](required = false,
descr = "Cluster platform where Spark CPU workloads were executed. Options include " +
"onprem, dataproc-t4, dataproc-l4, dataproc-serverless-l4, dataproc-gke-t4, " +
"dataproc-gke-l4, emr-t4, emr-a10, databricks-aws, and databricks-azure. Default " +
"is onprem.",
s"${PlatformTypes.getAllPlatformNames.mkString(", ")}. Default is ${PlatformTypes.ONPREM}.",
default = Some("onprem"))
val speedupFactorFile: ScallopOption[String] =
opt[String](required = false,
Expand Down

0 comments on commit ddf3aa4

Please sign in to comment.