Skip to content

Commit

Permalink
[FEA] Sync up conv function with rapids-plugin resources (#573)
Browse files Browse the repository at this point in the history
* updated supported exprs files to include conv and added unit test

Signed-off-by: cindyyuanjiang <[email protected]>

* removed unit test since conv is marked unsupported

Signed-off-by: cindyyuanjiang <[email protected]>

* updated exprs in operatorList file

Signed-off-by: cindyyuanjiang <[email protected]>

---------

Signed-off-by: cindyyuanjiang <[email protected]>
  • Loading branch information
cindyyuanjiang authored Sep 21, 2023
1 parent fd0541e commit 8137d8f
Show file tree
Hide file tree
Showing 9 changed files with 16 additions and 0 deletions.
1 change: 1 addition & 0 deletions core/src/main/resources/operatorsScore-databricks-aws.csv
Original file line number Diff line number Diff line change
Expand Up @@ -75,6 +75,7 @@ CollectSet,2.45
Concat,2.45
ConcatWs,2.45
Contains,2.45
Conv,2.45
Cos,2.45
Cosh,2.45
Cot,2.45
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -75,6 +75,7 @@ CollectSet,2.73
Concat,2.73
ConcatWs,2.73
Contains,2.73
Conv,2.73
Cos,2.73
Cosh,2.73
Cot,2.73
Expand Down
1 change: 1 addition & 0 deletions core/src/main/resources/operatorsScore-dataproc-l4.csv
Original file line number Diff line number Diff line change
Expand Up @@ -75,6 +75,7 @@ CollectSet,4.16
Concat,4.16
ConcatWs,4.16
Contains,4.16
Conv,4.16
Cos,4.16
Cosh,4.16
Cot,4.16
Expand Down
1 change: 1 addition & 0 deletions core/src/main/resources/operatorsScore-dataproc-t4.csv
Original file line number Diff line number Diff line change
Expand Up @@ -75,6 +75,7 @@ CollectSet,4.88
Concat,4.88
ConcatWs,4.88
Contains,4.88
Conv,4.88
Cos,4.88
Cosh,4.88
Cot,4.88
Expand Down
1 change: 1 addition & 0 deletions core/src/main/resources/operatorsScore-emr-a10.csv
Original file line number Diff line number Diff line change
Expand Up @@ -75,6 +75,7 @@ CollectSet,2.59
Concat,2.59
ConcatWs,2.59
Contains,2.59
Conv,2.59
Cos,2.59
Cosh,2.59
Cot,2.59
Expand Down
1 change: 1 addition & 0 deletions core/src/main/resources/operatorsScore-emr-t4.csv
Original file line number Diff line number Diff line change
Expand Up @@ -75,6 +75,7 @@ CollectSet,2.07
Concat,2.07
ConcatWs,2.07
Contains,2.07
Conv,2.07
Cos,2.07
Cosh,2.07
Cot,2.07
Expand Down
1 change: 1 addition & 0 deletions core/src/main/resources/operatorsScore.csv
Original file line number Diff line number Diff line change
Expand Up @@ -80,6 +80,7 @@ CollectSet,4
Concat,4
ConcatWs,4
Contains,4
Conv,4
Cos,4
Cosh,4
Cot,4
Expand Down
4 changes: 4 additions & 0 deletions core/src/main/resources/supportedExprs.csv
Original file line number Diff line number Diff line change
Expand Up @@ -127,6 +127,10 @@ ConcatWs,S,`concat_ws`,None,project,result,NA,NA,NA,NA,NA,NA,NA,NA,NA,S,NA,NA,NA
Contains,S, ,None,project,src,NA,NA,NA,NA,NA,NA,NA,NA,NA,S,NA,NA,NA,NA,NA,NA,NA,NA
Contains,S, ,None,project,search,NA,NA,NA,NA,NA,NA,NA,NA,NA,PS,NA,NA,NA,NA,NA,NA,NA,NA
Contains,S, ,None,project,result,S,NA,NA,NA,NA,NA,NA,NA,NA,NA,NA,NA,NA,NA,NA,NA,NA,NA
Conv,NS,`conv`,This is disabled by default because GPU implementation is incomplete. We currently only support from/to_base values of 10 and 16. We fall back on CPU if the signed conversion is signalled via a negative to_base. GPU implementation does not check for an 64-bit signed/unsigned int overflow when performing the conversion to return `FFFFFFFFFFFFFFFF` or `18446744073709551615` or to throw an error in the ANSI mode. It is safe to enable if the overflow is not possible or detected externally. For instance decimal strings not longer than 18 characters / hexadecimal strings not longer than 15 characters disregarding the sign cannot cause an overflow. ,project,num,NA,NA,NA,NA,NA,NA,NA,NA,NA,S,NA,NA,NA,NA,NA,NA,NA,NA
Conv,NS,`conv`,This is disabled by default because GPU implementation is incomplete. We currently only support from/to_base values of 10 and 16. We fall back on CPU if the signed conversion is signalled via a negative to_base. GPU implementation does not check for an 64-bit signed/unsigned int overflow when performing the conversion to return `FFFFFFFFFFFFFFFF` or `18446744073709551615` or to throw an error in the ANSI mode. It is safe to enable if the overflow is not possible or detected externally. For instance decimal strings not longer than 18 characters / hexadecimal strings not longer than 15 characters disregarding the sign cannot cause an overflow. ,project,from_base,NA,PS,PS,PS,PS,NA,NA,NA,NA,NA,NA,NA,NA,NA,NA,NA,NA,NA
Conv,NS,`conv`,This is disabled by default because GPU implementation is incomplete. We currently only support from/to_base values of 10 and 16. We fall back on CPU if the signed conversion is signalled via a negative to_base. GPU implementation does not check for an 64-bit signed/unsigned int overflow when performing the conversion to return `FFFFFFFFFFFFFFFF` or `18446744073709551615` or to throw an error in the ANSI mode. It is safe to enable if the overflow is not possible or detected externally. For instance decimal strings not longer than 18 characters / hexadecimal strings not longer than 15 characters disregarding the sign cannot cause an overflow. ,project,to_base,NA,PS,PS,PS,PS,NA,NA,NA,NA,NA,NA,NA,NA,NA,NA,NA,NA,NA
Conv,NS,`conv`,This is disabled by default because GPU implementation is incomplete. We currently only support from/to_base values of 10 and 16. We fall back on CPU if the signed conversion is signalled via a negative to_base. GPU implementation does not check for an 64-bit signed/unsigned int overflow when performing the conversion to return `FFFFFFFFFFFFFFFF` or `18446744073709551615` or to throw an error in the ANSI mode. It is safe to enable if the overflow is not possible or detected externally. For instance decimal strings not longer than 18 characters / hexadecimal strings not longer than 15 characters disregarding the sign cannot cause an overflow. ,project,result,NA,NA,NA,NA,NA,NA,NA,NA,NA,S,NA,NA,NA,NA,NA,NA,NA,NA
Cos,S,`cos`,None,project,input,NA,NA,NA,NA,NA,NA,S,NA,NA,NA,NA,NA,NA,NA,NA,NA,NA,NA
Cos,S,`cos`,None,project,result,NA,NA,NA,NA,NA,NA,S,NA,NA,NA,NA,NA,NA,NA,NA,NA,NA,NA
Cos,S,`cos`,None,AST,input,NA,NA,NA,NA,NA,NA,S,NA,NA,NA,NA,NA,NA,NA,NA,NA,NA,NA
Expand Down
5 changes: 5 additions & 0 deletions user_tools/custom_speedup_factors/operatorsList.csv
Original file line number Diff line number Diff line change
Expand Up @@ -68,6 +68,7 @@ CollectSet
Concat
ConcatWs
Contains
Conv
Cos
Cosh
Cot
Expand Down Expand Up @@ -148,6 +149,8 @@ MapKeys
MapValues
Max
Md5
MicrosToTimestamp
MillisToTimestamp
Min
Minute
MonotonicallyIncreasingID
Expand Down Expand Up @@ -186,6 +189,7 @@ RowNumber
ScalaUDF
ScalarSubquery
Second
SecondsToTimestamp
Sequence
ShiftLeft
ShiftRight
Expand All @@ -210,6 +214,7 @@ StringRepeat
StringReplace
StringSplit
StringToMap
StringTranslate
StringTrim
StringTrimLeft
StringTrimRight
Expand Down

0 comments on commit 8137d8f

Please sign in to comment.